Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Set BASIC auth with no respect to remote server #218

Merged
merged 1 commit into from
Mar 7, 2020
Merged

feat(auth): Set BASIC auth with no respect to remote server #218

merged 1 commit into from
Mar 7, 2020

Conversation

ivanilves
Copy link
Owner

@ivanilves ivanilves commented Mar 7, 2020 •
edited
Loading

Need to support setting BASIC credentials for Artifactory to try to avoid things like #214 🤷‍♂️

@coveralls
Copy link

coveralls commented Mar 7, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.5%) to 91.233% when pulling 26ee146 on auth-headers into d901dcd on master.

vonrabbe
vonrabbe approved these changes Mar 7, 2020
View reviewed changes
Copy link
Collaborator

@vonrabbe vonrabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

farther we go, hackier we get 😄

@vonrabbe vonrabbe merged commit 6b3aeb6 into master Mar 7, 2020
@vonrabbe vonrabbe deleted the auth-headers branch March 7, 2020 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vonrabbe vonrabbe vonrabbe approved these changes

@zealic zealic Awaiting requested review from zealic

@lukeb2e lukeb2e Awaiting requested review from lukeb2e

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivanilves @coveralls @vonrabbe