New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disables serde-serializer feature from wasm-bindgen dep #83

Merged

ivanceras merged 1 commit into ivanceras:master from iamricard:master

Oct 29, 2023

Contributor

iamricard commented Oct 28, 2023 •

edited

Loading

👋🏼 hi! i hope this unannounced PR is fine.

this looks to disable the serde-serialize feature from the wasm-bindgen dep on sauron-core, which looks like was added about 3 years ago and is now unused. the reason for this is to break a possible dependency cycle as explained in rustwasm/wasm-bindgen#2770. i'm a bit of a novice when it comes to rust, but from what i can tell there are no uses of into_serde (https://github.com/rustwasm/wasm-bindgen/blob/a03d23bd16cb9b1706a71f20ba062e5532b369ec/src/lib.rs#L249-L258) or from_serde anymore (https://github.com/rustwasm/wasm-bindgen/blob/a03d23bd16cb9b1706a71f20ba062e5532b369ec/src/lib.rs#L218-L224).

ran just test-all and all passed on a darwin arm64 host ✅


          disables serde-serializer feature from wasm-bindgen dep

d9d2f20

ivanceras merged commit 2053eeb into ivanceras:master

4 checks passed

Owner

ivanceras commented Oct 29, 2023

This is a good PR, thank you @iamricard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet