deps: refresh the lock files for the four out-of-slnx projects - #168
Merged
Conversation
The solution-wide restore only reaches projects listed in MMCA.Common.slnx, so the four that deliberately sit outside it kept stale "requested" versions after the analyzer bumps in #162 and earlier: - Source/Presentation/MMCA.Common.UI.Maui (ADR-042, its own windows job) - Tests/Presentation/MMCA.Common.UI.E2E.Tests - Tests/Presentation/MMCA.Common.UI.Gallery - Tests/Core/MMCA.Common.Infrastructure.Redis.Tests Meziantou.Analyzer 3.0.123/3.0.124 to 3.0.133, SonarAnalyzer.CSharp 10.29.0.143774 to 10.30.0.144632, and the Microsoft.IdentityModel transitives 8.19.2 to 8.21.0, all now matching Directory.Packages.props. No behavior change. CI restores without --locked-mode (ci.yml:85), so these projects were already compiling against the current analyzers; this only realigns the recorded lock state. The three non-MAUI projects build clean in Release locally, and MAUI is covered by its dedicated windows job. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regenerates
packages.lock.jsonfor the four projects that deliberately sit outsideMMCA.Common.slnx:Source/Presentation/MMCA.Common.UI.MauiTests/Presentation/MMCA.Common.UI.E2E.Testsdotnet test --solutionstays fastTests/Presentation/MMCA.Common.UI.GalleryTests/Core/MMCA.Common.Infrastructure.Redis.TestsWhy
dotnet restore <slnx> --force-evaluateonly reaches projects listed in the solution, so these four never got refreshed when the analyzers were bumped in #162 and earlier. They had drifted toMeziantou.Analyzer3.0.123/3.0.124 andSonarAnalyzer.CSharp10.29.0.143774 whileDirectory.Packages.propspins 3.0.133 and 10.30.0.144632.Changes are
Meziantou.Analyzer-> 3.0.133,SonarAnalyzer.CSharp-> 10.30.0.144632, andMicrosoft.IdentityModel.*transitives 8.19.2 -> 8.21.0.Risk
None expected. CI restores without
--locked-mode(ci.yml:85: "the props file is what actually pins their versions"), so these projects were already compiling against the current analyzers in CI. This only realigns the recorded lock state so the files stop misreporting.The diff is exactly balanced at 165 insertions / 165 deletions: version records only, no packages added or removed.
Verification
Directory.Packages.props; no in-slnx lock file moved.dotnet build -c Releaseclean on all three non-MAUI projects.