deps: Bump the analyzers group with 2 updates - #147
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps Meziantou.Analyzer from 3.0.124 to 3.0.133 Bumps SonarAnalyzer.CSharp from 10.29.0.143774 to 10.30.0.144632 --- updated-dependencies: - dependency-name: Meziantou.Analyzer dependency-version: 3.0.133 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: analyzers - dependency-name: SonarAnalyzer.CSharp dependency-version: 10.30.0.144632 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: analyzers ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
.NET
dependabot
Bot
added
dependencies
This was referenced Jul 28, 2026
ivanball
added a commit
that referenced
this pull request
Jul 28, 2026
Replaces six of the seven open Dependabot PRs with one, and adds the grouping config so this stops recurring. Bumps (#146, #148, #149, #150, #153, #154): actions/cache 4 -> 6 Azure.Monitor.OpenTelemetry.AspNetCore 1.5.0 -> 1.6.0 AngleSharp 1.5.2 -> 1.6.0 bunit 2.7.2 -> 2.8.6 SQLitePCLRaw.bundle_e_sqlite3 3.0.4 -> 3.0.5 System.IdentityModel.Tokens.Jwt 8.19.2 -> 8.21.0 Built by applying the version lines to Directory.Packages.props and running ONE dotnet restore --force-evaluate, rather than merging the six branches. Merging them would have conflicted: they touch overlapping packages.lock.json files (AngleSharp and bunit hit the same two), and every merge re-BEHINDs the rest under "require branches to be up to date". Regenerating sidesteps that entirely. NOT included: #147 (analyzers group). SonarAnalyzer 10.29 -> 10.30 ships two new rules, S8969 and S8970, which fail this build with 41 errors across 11 files under TreatWarningsAsErrors. Those are mechanical (remove a redundant null-forgiving operator) but they are analyzer remediation, not a dependency bump, and they belong in their own reviewable PR. #147 stays open. dependabot.yml gains two groups. "testing" keeps bUnit and its AngleSharp dependency in one PR instead of two that touch the same lock files. "minor-and-patch" is a catch-all so ungrouped minor/patch updates arrive weekly as one PR: this repo has 13 required checks including a MAUI windows build, three browser a11y legs, a BenchmarkDotNet gate and a Testcontainers Redis tier, so N separate dependency PRs cost N full re-runs. Majors stay ungrouped, since those deserve their own read. Full solution 2483/2483 green in Release, 0 warnings; 15 lock files regenerated. Claude-Session: https://claude.ai/code/session_01RpWirEitGZ2AMEQhd7NCD9 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Superseded by #163. |
ivanball
added a commit
that referenced
this pull request
Jul 28, 2026
Completes the Dependabot sweep. Bumps Meziantou.Analyzer 3.0.124 -> 3.0.133 and SonarAnalyzer.CSharp 10.29.0.143774 -> 10.30.0.144632 (was #147), which was held out of the consolidated bump PR because 10.30 ships three new rules that fail this build under TreatWarningsAsErrors. S8949 (3 sites) is a REAL defect and is fixed properly. SoftDeletedUserMiddleware was calling the cache and the soft-delete validator without a CancellationToken, even though all three APIs accept one, so a client disconnect never cancelled the lookups. They now pass context.RequestAborted. S8969 (38 sites) is mostly right: 34 were genuine redundant null-forgiving operators and are removed. FOUR were wrong. At those the analyzer claimed the compiler already knew the expression was non-null, and removing the operator immediately failed with CS8602/CS8629. Those four are restored, and the rule is downgraded to a suggestion in .editorconfig: under TreatWarningsAsErrors a false positive is a broken build, not a nudge, so it cannot gate CI at that accuracy. S8970 (3 sites) is wrong at every site it flags here. It claims nullable warnings are disabled and the operator is pointless, but each site is the deliberate `null!` / `default!` initializer pattern in a .razor component, where removing it fails with CS8625/CS8604. Suppressed via NoWarn in Directory.Build.props rather than .editorconfig, because a dotnet_diagnostic severity does not reach Razor-generated code. The measured false-positive rate (7 of 41) is why neither nullability rule is left at error severity. The compiler is the authority on nullability, not the analyzer; both suppressions carry that reasoning inline for whoever revisits them. Full solution 2483/2483 green in Release, 0 warnings; facts --check clean; 25 lock files regenerated. Claude-Session: https://claude.ai/code/session_01RpWirEitGZ2AMEQhd7NCD9 Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated Meziantou.Analyzer from 3.0.124 to 3.0.133.
Release notes
Sourced from Meziantou.Analyzer's releases.
3.0.133
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.133
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.132...3.0.133
3.0.132
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.132
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.130...3.0.132
3.0.131
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.131
What's Changed
[with(StringComparer.Ordinal)]collection expression by @meziantou in Fix MA0002 false positive on[with(StringComparer.Ordinal)]collection expression meziantou/Meziantou.Analyzer#1237Full Changelog: meziantou/Meziantou.Analyzer@3.0.129...3.0.131
3.0.130
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.130
What's Changed
[with(StringComparer.Ordinal)]collection expression by @meziantou in Fix MA0002 false positive on[with(StringComparer.Ordinal)]collection expression meziantou/Meziantou.Analyzer#1237Full Changelog: meziantou/Meziantou.Analyzer@3.0.129...3.0.130
3.0.129
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.129
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.128...3.0.129
3.0.128
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.128
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.127...3.0.128
3.0.127
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.127
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.126...3.0.127
3.0.126
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.126
What's Changed
ImmutableDictionary.CreateBuilder<TKey, TValue>()without comparer by @meziantou with @Copilot in Enforce MA0002 forImmutableDictionary.CreateBuilder<TKey, TValue>()without comparer meziantou/Meziantou.Analyzer#1227Full Changelog: meziantou/Meziantou.Analyzer@3.0.125...3.0.126
3.0.125
NuGet package: https://www.nuget.org/packages/Meziantou.Analyzer/3.0.125
What's Changed
Full Changelog: meziantou/Meziantou.Analyzer@3.0.124...3.0.125
Commits viewable in compare view.
Updated SonarAnalyzer.CSharp from 10.29.0.143774 to 10.30.0.144632.
Release notes
Sourced from SonarAnalyzer.CSharp's releases.
10.30.0.144632
Release notes - .NET Analyzers - 10.30
Feature
NET-1536 Implement rule S8970: Null-forgiving operators should not be used when nullable warnings are disabled
NET-3436 Implement rule S8949: Use the overload that accepts a CancellationToken
NET-3810 Fix: Protobuf Importer logs debug on excluded files
NET-3877 Implement rule S8747: Migrations should not narrow column types without converting existing data
NET-4091 Implement rule S8969: Null-forgiving operators should not be redundant
NET-4120 Update RSPEC before 10.30 release
False Positive
NET-1541 Fix S3459 FP: support classes marked with [AutoConstructor] attribute
NET-1583 Fix S6967 FP: Raises when model has no validation attributes
NET-1840 Fix S3903 FP: top-level statements and partial Program in separate file
NET-4059 Improve precision of S8949 (CancellationTokenShouldBeUsed) - umbrella
NET-4191 Fix S3169 FP: Should not raise in Azure Cosmos
False Negative
NET-3819 Fix S1244 FN: Should report on Double.Equals
Bug
NET-4107 Fix S4026 Race Condition
Commits viewable in compare view.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions