Fix last character disappearance if emoji are in comment #5587
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code use UTF-8 to count characters however Emojis are UTF-16 units. This difference leads to misalignment of index offsets.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a text truncation bug where the final character(s) of YouTube-provided text (notably comments) could be dropped when the text contains emoji/SMP codepoints, by aligning string-length accounting with YouTube’s UTF-16 indexing semantics.
Changes:
- Added a helper to compute UTF-16 code unit length for a
String. - Updated
parse_descriptionto use UTF-16 code unit length instead ofString#sizewhen copying/escaping content. - Updated remaining-length calculation to be consistent with UTF-16 indexing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #5503