Fix parsing shorts on channel page #3700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
requested review from
SamantazFox
and removed request for
a team
ChunkyProgrammer
force-pushed
the
fix-shorts
branch
from
e3ddacf to
5767344
Compare
Member
|
In testing on https://yewtu.be |
SamantazFox
approved these changes
Mar 31, 2023
Member
|
view count extraction would need to be fixed, too (it's missing the multiplier) |
unixfox
approved these changes
Apr 1, 2023
Member
unixfox
left a comment
unixfox
left a comment
There was a problem hiding this comment.
No issues on my side, I have been testing it for more than one week.
4 tasks
|
i have been testing it for weeks - it works fineu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3637
As I am not 100% sure if they phased the old type out of all channels, I kept it in just in case. For now, we are able to get author name and author id from fallback but we cannot get published date.
Test:
go to:
/channel/UCghooJjCGtg2Kw2PSB9B0NA/shortsgo to
/api/v1/channels/UCghooJjCGtg2Kw2PSB9B0NA/shorts