Variable postgres username and database name in migration scripts#2451
Merged
syeopite merged 1 commit intoiv-org:masterfrom Oct 11, 2021
JuniorJPDJ:db
Merged
Variable postgres username and database name in migration scripts#2451syeopite merged 1 commit intoiv-org:masterfrom JuniorJPDJ:db
syeopite merged 1 commit intoiv-org:masterfrom
JuniorJPDJ:db
Conversation
JuniorJPDJ
changed the title
TheFrenchGhosty
added
need-code-review
syeopite
reviewed
Oct 5, 2021
SamantazFox
approved these changes
Oct 7, 2021
syeopite
added
ready
and removed
need-code-review
TheFrenchGhosty
approved these changes
Oct 11, 2021
Member
TheFrenchGhosty
left a comment
TheFrenchGhosty
left a comment
There was a problem hiding this comment.
Finally something I can actually review... shell scripts xD
Member
|
Thanks @JuniorJPDJ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied additional changes mentioned in #1678
PS. Could you guys please add
hacktoberfest-acceptedlabel to this PR?I'd like to take part in hacktoberfest.
EDIT: NVM, I see project is already tagged with
hacktoberfesttopic.