-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Add Plyr Video Player Option #544
Comments
Quite impressive list of features from a quick look. Unfortunately there's a couple plugins being used with Video.js that I don't see a good Plyr alternative for:
Overall I can see this being an improvement over the current player. Unfortunately I won't have time to look into this much more, but I'd happily look at any PRs adding support for it. |
@trymeouteh maybe write a feature suggestion on plyrs github for what is missing if these things are not yet possible with plyr. |
I made a feature request for the video markers on Plyr github. The annotations are legacy if Plyr does not support them, those who want annotations should use the current player. The share button can be added outside the video player and I do believe you can add custom buttons within the player. |
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
I'd hate for this feature request to be closed. It's such a good idea!! Plyr.io is a beautiful player. I understand the concerns, such as regarding legacy annotations (someone created an issue on it at Plyr's github but unfortunately it was closed.) I hope this can be implemented one day, it'd be a great step forward for Invidious! |
Annotations have been removed completely, so they are not a problem anymore. |
This issue has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely outdated. If you think this issue is still relevant and applicable, you just have to post a comment and it will be unmarked. |
This is a good feature request. |
We can't support plyr until this issue is resolved: sampotts/plyr#1455 |
Interesting. Do you know how Invuedious does it? (If you get a connection error, just click the settings and select a working instance like invidious.osi.kr.) |
They don't use dash, that's it. You can't go over 720p, so they don't offer dash which is a technology that mix both audio and video at the same time. That's what Youtube uses and if you want to watch 1080p+ videos you need to use dash. More about dash here: https://docs.invidious.io/Geoblocking,-available-video-quality-and-DASH.md |
Closing as plyr is going to be abandonned: sampotts/plyr#2408 and the successor only support the very latest version of popular browsers: https://github.com/vidstack/player#%EF%B8%8F-browsers so we don't really want to restrict the amount of people using Invidious. |
Hey @unixfox just to clarify that on Vidstack we're not on the bleeding edge of modern browsers. Pretty much all numbers before our supported versions is |
Hi @mihar-22. Thanks for your comment. Our user base contains people that are using browsers that are not supported by www.youtube.com and thus use Invidious in order to still watch YouTube videos. This includes the browsers that are way older than the one listed here: https://github.com/vidstack/player#%EF%B8%8F-browsers We also have users using forks of Firefox, one popular fork: https://www.palemoon.org/. Palemoon is based on Firefox 52. Unfortunately, the usage statistics from caniuse doesn't represent the real user base of Invidious. |
https://plyr.io/
Plyr is a great video player with a nice UI and easy to use controls. I like using it on mobile devices and find it very user friendly.
I would prefer this over the current video player but I know some people will like the current video player over Plyr. I would to suggest to have them both and in the preferences you can choose which video player to use.
The text was updated successfully, but these errors were encountered: