Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle module refcount during init errors #37

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Conversation

iustin
Copy link
Owner

@iustin iustin commented Oct 10, 2022

Together with the commit in #36, this should fix issue #35,

Together with the commit in #36, this should fix issue #35,
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Base: 87.77% // Head: 87.60% // Decreases project coverage by -0.17% ⚠️

Coverage data is based on head (98919e1) compared to base (5234c00).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   87.77%   87.60%   -0.18%     
==========================================
  Files           1        1              
  Lines         499      500       +1     
==========================================
  Hits          438      438              
- Misses         61       62       +1     
Impacted Files Coverage Δ
xattr.c 87.60% <0.00%> (-0.18%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iustin iustin merged commit bfc62d8 into master Oct 10, 2022
@iustin iustin deleted the mod-init-errors branch October 10, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Memory leak bugs due to returned new reference is not decreased on failure (static analyzer reports)
1 participant