This repository has been archived by the owner on Jan 17, 2025. It is now read-only.
Support reload on change workflow again #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the options for
initRemixto also accept a path to the server build. A path will make it behave as it did before v1.0.0: on each HTTP request, purge the require cache, then require the server build. This should allow changes to be shown on reload again, without having to restart the entire electron app.Passing the full server build is still supported, so this isn't a breaking change, but seeing changes on refresh requires passing a path.
Using a separate server build also means we can't use the server build feature for a TS entry anymore 🥲 but if it's between that and reload on change, I'll pick the second any day.