Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discord.js adapter's methods more descriptive #40

Merged
merged 12 commits into from
Oct 28, 2023
Merged

Make discord.js adapter's methods more descriptive #40

merged 12 commits into from
Oct 28, 2023

Conversation

domin-mnd
Copy link
Collaborator

Still lacks some test & ComponentEvent interface rewrite. Hopefully it will be done either today or tomorrow.

itsMapleLeaf
itsMapleLeaf reviewed Oct 22, 2023
View reviewed changes
Copy link
Owner

@itsMapleLeaf itsMapleLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Here's some preemptive comments

packages/reacord/library/core/reacord-discord-js.ts Show resolved Hide resolved
packages/reacord/library/core/reacord-discord-js.ts Outdated Show resolved Hide resolved
packages/reacord/library/core/reacord.tsx Outdated Show resolved Hide resolved
@itsMapleLeaf itsMapleLeaf changed the base branch from main to dev October 23, 2023 15:42
@itsMapleLeaf
Copy link
Owner

Heads up: I changed the base on this to point to a new dev branch, which is also where I'll put the new documentation updates so they don't get deployed right away

@domin-mnd domin-mnd self-assigned this Oct 23, 2023
@domin-mnd
Copy link
Collaborator Author

domin-mnd commented Oct 23, 2023 •
edited
Loading

Hopefully, I did not miss anything in guides. I'm not sure how I should implement options for test adapter

itsMapleLeaf
itsMapleLeaf reviewed Oct 23, 2023
View reviewed changes
Copy link
Owner

@itsMapleLeaf itsMapleLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guide updates look good! Just a comment on the actual API, which I wish I noticed sooner 😅

As for options on the tester, that's not a public API anyway, so we don't need to worry about that for now, just as long as our tests pass

packages/reacord/scripts/discordjs-manual-test.tsx Outdated Show resolved Hide resolved
@domin-mnd domin-mnd marked this pull request as ready for review October 27, 2023 13:10
itsMapleLeaf
itsMapleLeaf approved these changes Oct 28, 2023
View reviewed changes
Copy link
Owner

@itsMapleLeaf itsMapleLeaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks again! 🙌

@itsMapleLeaf itsMapleLeaf merged commit cdc22b7 into itsMapleLeaf:dev Oct 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsMapleLeaf itsMapleLeaf itsMapleLeaf approved these changes

Assignees

@domin-mnd domin-mnd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domin-mnd @itsMapleLeaf