This repository was archived by the owner on Dec 3, 2025. It is now read-only.
Use alloy execution payload type#74
Merged
refcell merged 2 commits intoithacaxyz:mainfrom Sep 3, 2024
Merged
Conversation
refcell
suggested changes
Sep 1, 2024
Contributor
refcell
left a comment
refcell
left a comment
There was a problem hiding this comment.
Few requests, otherwise great work
refcell
approved these changes
Sep 2, 2024
Contributor
|
Resolve the conflicts and this is godo to go 👍 Very nice work! |
Signed-off-by: Chen Kai <281165273grape@gmail.com>
Signed-off-by: Chen Kai <281165273grape@gmail.com>
refcell
approved these changes
Sep 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #51.
This PR remove all the custom
ExecutionPayload*structs and use upstream alloy payload instead.I think
convert_payload*function could be implemented in kona useFromtrait, does it make sense? @refcell