Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Get-ITGlueLogs & Added support for the Australian datacenter #139

Merged
merged 18 commits into from
Dec 2, 2022

Conversation

Celerium
Copy link
Contributor

@Celerium Celerium commented Jan 16, 2022

Apologies as I am new to Git\GitHub, please let me know if I am doing this wrong and ill do my best to fix it.

  1. Added support to get ITGlue logs.
  • New Get Logs API Capability Enhancement #137
  • The sort parameter allows for 'created_at', 'updated_at', '-created_at', '-updated_at'. Though in my testing I am unsure what the 'updated_at' & '-updated_at' are pulling from as there are no values in the returned data nor are they options in any of ITGlue's logs graphically. The data does sort correctly though when the options are inputted.
  1. Added support for the Australian datacenter
  • I am unable to fully test as my ITGlue instance is US-based
  1. Fixed various minor spelling mistakes & trailing spaces.

  2. Updated ModuleVersion to 2.2.0 & adjusted any related items for function imports\tests.

@Celerium Celerium changed the title Added support for the Australia datacenter New Get-ITGlueLogs & Added support for the Australian datacenter Jan 16, 2022
@davidhaymond
Copy link
Collaborator

Great PR. Thanks for the trailing whitespace cleanup. My only comment is that the documentation lists created_at only, so updated_at and -updated_at should be removed from the list of allowed sort values.

Copy link
Contributor

@CalebAlbers CalebAlbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, @Celerium! Both the logs endpoint and support for AU are really impactful features

ITGlueAPI/ITGlueAPI.psd1 Outdated Show resolved Hide resolved
@Celerium
Copy link
Contributor Author

Celerium commented Dec 1, 2022

Weird I could have sworn those were there at some point. Either way, I updated the parameters, tested them, and added comment-based help. There is another parameter that can be added in the future.

ITGlue Logs

  • filter[created_at]
  • It would have to be a DateTime input from the looks of it that could also accept a wildcard of '*'.

@CalebAlbers CalebAlbers merged commit f58751d into itglue:master Dec 2, 2022
@CalebAlbers
Copy link
Contributor

Thanks again for this! Loving the comment-based help, too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants