-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve relative paths as urls #209
Conversation
@brunocodutra can we add tests to avoid problem in future? |
@evilebottnawi Yes, we should add regression tests for this one, I'll work on that |
Pull Request Test Coverage Report for Build 386
💛 - Coveralls |
9568f08
to
cfce658
Compare
@evilebottnawi I just added the missing regression tests, could you take a look again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Need resolve why appveyor failed
@evilebottnawi Node sometimes runs out of memory on windows, maybe tackling #158 helps. |
This is a direct port of #184
Closes #184
Closes #189
Fixes #182