Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve relative paths as urls #209

Merged
merged 4 commits into from
Mar 31, 2018
Merged

Resolve relative paths as urls #209

merged 4 commits into from
Mar 31, 2018

Conversation

brunocodutra
Copy link
Collaborator

This is a direct port of #184

Closes #184
Closes #189
Fixes #182

@alexander-akait
Copy link
Member

@brunocodutra can we add tests to avoid problem in future?

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi Yes, we should add regression tests for this one, I'll work on that

@coveralls
Copy link

coveralls commented Mar 30, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 386

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 77.294%
Totals Coverage Status
Change from base Build 384: 0.3%
Covered Lines: 249
Relevant Lines: 303
💛 - Coveralls

@brunocodutra
Copy link
Collaborator Author

@evilebottnawi I just added the missing regression tests, could you take a look again

alexander-akait
alexander-akait approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Need resolve why appveyor failed

@brunocodutra
Copy link
Collaborator Author

Looks good! Need resolve why appveyor failed

@evilebottnawi Node sometimes runs out of memory on windows, maybe tackling #158 helps.

@brunocodutra brunocodutra merged commit b0ea080 into master Mar 31, 2018
@brunocodutra brunocodutra deleted the url/resolve branch March 31, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brunocodutra @alexander-akait @coveralls