Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
1.
source
parameter as argumentIn documentation we can see:
but according to the code it should be map, not array:
Now source can be array of paths. And better to use
sizeOf
function instead of:2. Firefox icon
Overlay should be behind main icon.
Icon from RFG:
Before (without offset):
After (with offset):
3. HTML tags from RFG
Before:
After:
4. Offset fix
5. Convert color to HEX for RFG
RFG throws error if color is not in HEX format. Now color converts to HEX.
Mods
1. Partial offline SVG support
Now if sourceset contains SVG source, new image will be generated instead of resizing PNG source.
Before (from 512x512 PNG):
After (from SVG):
2. Offsets with RFG
Now offset parameters will be applied to the RFG request.
3. Platform options
Certain parameters can be applied for certain platforms. This rules are described in
config/platform-options.json
. For now it has only one parameter, but in near future I can add some parameters from RFG, which will be available only withonline: true
.4. Prefer online option
If
preferOnline
option is setted totrue
andonline
generation was failed, then icons will be generated offline.