tests: api: convert to dir helpers #3044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
commented
Jan 3, 2020
|
|
||
|
|
||
| # TODO: simplify, we shouldn't need run. |
There was a problem hiding this comment.
I don't think there is an easy way to have a non-cached file without run, an alternative could be add-ing and modifying stage file, but that is artificial, and probably will not require less work than run.
pared
changed the title
This comment has been minimized.
This comment has been minimized.
Suor
suggested changes
Jan 3, 2020
tests/func/test_api.py
Outdated
|
|
||
| with pytest.raises(FileMissingError): | ||
| api.read("foo") | ||
| api.read("foo", repo=fspath(erepo_dir)) |
There was a problem hiding this comment.
This one uses dir helpers already, no need to complicate it.
tests/func/test_api.py
Outdated
| # TODO: simplify, we shouldn't need run. | ||
| def test_open_not_cached(dvc): | ||
| metric_file = "metric.txt" | ||
| def test_open_not_cached(dvc, erepo_dir, monkeypatch): |
There was a problem hiding this comment.
No need to use erepo_dir here.
pared
changed the title
efiop
approved these changes
Jan 3, 2020
Suor
approved these changes
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Have you followed the guidelines in the Contributing to DVC list?
📖 Check this box if this PR does not require documentation updates, or if it does and you have created a separate PR in dvc.org with such updates (or at least opened an issue about it in that repo). Please link below to your PR (or issue) in the dvc.org repo.
❌ Have you checked DeepSource, CodeClimate, and other sanity checks below? We consider their findings recommendatory and don't expect everything to be addressed. Please review them carefully and fix those that actually improve code or fix bugs.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏