deps: bump minver for celery/kombu to 5.3.0 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jun 13, 2023
| @@ -121,7 +113,7 @@ def _iter_folder( | |||
| queue: Optional name of queue. | |||
| """ | |||
| with self.connection_for_read() as conn: # type: ignore[attr-defined] | |||
| with conn.channel() as channel: | |||
| with conn.channel() as channel: # type: ignore[attr-defined] | |||
There was a problem hiding this comment.
celery-types does not have type stub for Channel as a contextmanager yet.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
+ Coverage 78.15% 85.79% +7.64%
==========================================
Files 21 20 -1
Lines 1007 838 -169
Branches 154 129 -25
==========================================
- Hits 787 719 -68
+ Misses 194 97 -97
+ Partials 26 22 -4
☔ View full report in Codecov by Sentry. |
skshetry
commented
Jun 13, 2023
|
celery-types>=0.16.0 uses typing features that are only available on Python 3.10+, so I have pinned it to 0.15.0 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.