Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load dvc.testing.plugin for benchmarks #65

Merged
merged 3 commits into from
Mar 1, 2024
Merged

load dvc.testing.plugin for benchmarks #65

merged 3 commits into from
Mar 1, 2024

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Mar 1, 2024

No description provided.

skshetry
skshetry commented Mar 1, 2024
View reviewed changes
pyproject.toml
@@ -69,7 +69,7 @@ Source = "https://github.com/iterative/dvc-s3"

[tool.pytest.ini_options]
log_level = "debug"
addopts = "-ra"
addopts = "-ra -pdvc.testing.plugin"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot keep this inside conftest.py.

pytest_plugins = ["dvc.testing.plugin"]

pytest only supports them if they are at the top-level, eg: tests/conftest.py. But the tests package in dvc-s3 is inside dvc_s3/tests.

@skshetry skshetry force-pushed the load-dvc-testing-plugin branch from a28d08f to 54e7e8a Compare March 1, 2024 06:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 


------------------------------------------------------------------------ benchmark 'test_sharing_s3-add': 7 tests ------------------------------------------------------------------------
Name (time in s)                   Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add[2.11.0]     5.4692 (1.64)     5.4692 (1.64)     5.4692 (1.64)     0.0000 (1.0)      5.4692 (1.64)     0.0000 (1.0)           0;0  0.1828 (0.61)          1           1
test_sharing_s3-add[2.18.1]     4.9316 (1.48)     4.9316 (1.48)     4.9316 (1.48)     0.0000 (1.0)      4.9316 (1.48)     0.0000 (1.0)           0;0  0.2028 (0.68)          1           1
test_sharing_s3-add[2.39.0]     5.1042 (1.53)     5.1042 (1.53)     5.1042 (1.53)     0.0000 (1.0)      5.1042 (1.53)     0.0000 (1.0)           0;0  0.1959 (0.65)          1           1
test_sharing_s3-add[2.40.0]     4.6674 (1.40)     4.6674 (1.40)     4.6674 (1.40)     0.0000 (1.0)      4.6674 (1.40)     0.0000 (1.0)           0;0  0.2143 (0.72)          1           1
test_sharing_s3-add[2.41.1]     4.6885 (1.40)     4.6885 (1.40)     4.6885 (1.40)     0.0000 (1.0)      4.6885 (1.40)     0.0000 (1.0)           0;0  0.2133 (0.71)          1           1
test_sharing_s3-add[2.45.0]     3.4503 (1.03)     3.4503 (1.03)     3.4503 (1.03)     0.0000 (1.0)      3.4503 (1.03)     0.0000 (1.0)           0;0  0.2898 (0.97)          1           1
test_sharing_s3-add[main]       3.3381 (1.0)      3.3381 (1.0)      3.3381 (1.0)      0.0000 (1.0)      3.3381 (1.0)      0.0000 (1.0)           0;0  0.2996 (1.0)           1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-add-noop': 7 tests ------------------------------------------------------------------------
Name (time in s)                        Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add-noop[2.11.0]     2.1210 (1.0)      2.1210 (1.0)      2.1210 (1.0)      0.0000 (1.0)      2.1210 (1.0)      0.0000 (1.0)           0;0  0.4715 (1.0)           1           1
test_sharing_s3-add-noop[2.18.1]     2.3536 (1.11)     2.3536 (1.11)     2.3536 (1.11)     0.0000 (1.0)      2.3536 (1.11)     0.0000 (1.0)           0;0  0.4249 (0.90)          1           1
test_sharing_s3-add-noop[2.39.0]     2.2834 (1.08)     2.2834 (1.08)     2.2834 (1.08)     0.0000 (1.0)      2.2834 (1.08)     0.0000 (1.0)           0;0  0.4379 (0.93)          1           1
test_sharing_s3-add-noop[2.40.0]     2.2906 (1.08)     2.2906 (1.08)     2.2906 (1.08)     0.0000 (1.0)      2.2906 (1.08)     0.0000 (1.0)           0;0  0.4366 (0.93)          1           1
test_sharing_s3-add-noop[2.41.1]     2.2405 (1.06)     2.2405 (1.06)     2.2405 (1.06)     0.0000 (1.0)      2.2405 (1.06)     0.0000 (1.0)           0;0  0.4463 (0.95)          1           1
test_sharing_s3-add-noop[2.45.0]     2.2988 (1.08)     2.2988 (1.08)     2.2988 (1.08)     0.0000 (1.0)      2.2988 (1.08)     0.0000 (1.0)           0;0  0.4350 (0.92)          1           1
test_sharing_s3-add-noop[main]       2.2688 (1.07)     2.2688 (1.07)     2.2688 (1.07)     0.0000 (1.0)      2.2688 (1.07)     0.0000 (1.0)           0;0  0.4408 (0.93)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-checkout': 7 tests ------------------------------------------------------------------------
Name (time in s)                        Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-checkout[2.11.0]     1.7759 (1.31)     1.7759 (1.31)     1.7759 (1.31)     0.0000 (1.0)      1.7759 (1.31)     0.0000 (1.0)           0;0  0.5631 (0.76)          1           1
test_sharing_s3-checkout[2.18.1]     1.7297 (1.28)     1.7297 (1.28)     1.7297 (1.28)     0.0000 (1.0)      1.7297 (1.28)     0.0000 (1.0)           0;0  0.5781 (0.78)          1           1
test_sharing_s3-checkout[2.39.0]     1.8062 (1.33)     1.8062 (1.33)     1.8062 (1.33)     0.0000 (1.0)      1.8062 (1.33)     0.0000 (1.0)           0;0  0.5537 (0.75)          1           1
test_sharing_s3-checkout[2.40.0]     1.7943 (1.32)     1.7943 (1.32)     1.7943 (1.32)     0.0000 (1.0)      1.7943 (1.32)     0.0000 (1.0)           0;0  0.5573 (0.75)          1           1
test_sharing_s3-checkout[2.41.1]     1.7844 (1.32)     1.7844 (1.32)     1.7844 (1.32)     0.0000 (1.0)      1.7844 (1.32)     0.0000 (1.0)           0;0  0.5604 (0.76)          1           1
test_sharing_s3-checkout[2.45.0]     1.7979 (1.33)     1.7979 (1.33)     1.7979 (1.33)     0.0000 (1.0)      1.7979 (1.33)     0.0000 (1.0)           0;0  0.5562 (0.75)          1           1
test_sharing_s3-checkout[main]       1.3543 (1.0)      1.3543 (1.0)      1.3543 (1.0)      0.0000 (1.0)      1.3543 (1.0)      0.0000 (1.0)           0;0  0.7384 (1.0)           1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_s3-checkout-noop': 7 tests ----------------------------------------------------------------------------
Name (time in ms)                              Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-checkout-noop[2.11.0]     402.0241 (1.0)      402.0241 (1.0)      402.0241 (1.0)      0.0000 (1.0)      402.0241 (1.0)      0.0000 (1.0)           0;0  2.4874 (1.0)           1           1
test_sharing_s3-checkout-noop[2.18.1]     469.1428 (1.17)     469.1428 (1.17)     469.1428 (1.17)     0.0000 (1.0)      469.1428 (1.17)     0.0000 (1.0)           0;0  2.1315 (0.86)          1           1
test_sharing_s3-checkout-noop[2.39.0]     501.1657 (1.25)     501.1657 (1.25)     501.1657 (1.25)     0.0000 (1.0)      501.1657 (1.25)     0.0000 (1.0)           0;0  1.9953 (0.80)          1           1
test_sharing_s3-checkout-noop[2.40.0]     503.6557 (1.25)     503.6557 (1.25)     503.6557 (1.25)     0.0000 (1.0)      503.6557 (1.25)     0.0000 (1.0)           0;0  1.9855 (0.80)          1           1
test_sharing_s3-checkout-noop[2.41.1]     489.4424 (1.22)     489.4424 (1.22)     489.4424 (1.22)     0.0000 (1.0)      489.4424 (1.22)     0.0000 (1.0)           0;0  2.0431 (0.82)          1           1
test_sharing_s3-checkout-noop[2.45.0]     523.5355 (1.30)     523.5355 (1.30)     523.5355 (1.30)     0.0000 (1.0)      523.5355 (1.30)     0.0000 (1.0)           0;0  1.9101 (0.77)          1           1
test_sharing_s3-checkout-noop[main]       538.1313 (1.34)     538.1313 (1.34)     538.1313 (1.34)     0.0000 (1.0)      538.1313 (1.34)     0.0000 (1.0)           0;0  1.8583 (0.75)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-fetch': 7 tests ------------------------------------------------------------------------
Name (time in s)                     Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-fetch[2.11.0]     9.3901 (1.22)     9.3901 (1.22)     9.3901 (1.22)     0.0000 (1.0)      9.3901 (1.22)     0.0000 (1.0)           0;0  0.1065 (0.82)          1           1
test_sharing_s3-fetch[2.18.1]     9.4261 (1.23)     9.4261 (1.23)     9.4261 (1.23)     0.0000 (1.0)      9.4261 (1.23)     0.0000 (1.0)           0;0  0.1061 (0.82)          1           1
test_sharing_s3-fetch[2.39.0]     9.5911 (1.25)     9.5911 (1.25)     9.5911 (1.25)     0.0000 (1.0)      9.5911 (1.25)     0.0000 (1.0)           0;0  0.1043 (0.80)          1           1
test_sharing_s3-fetch[2.40.0]     9.6210 (1.25)     9.6210 (1.25)     9.6210 (1.25)     0.0000 (1.0)      9.6210 (1.25)     0.0000 (1.0)           0;0  0.1039 (0.80)          1           1
test_sharing_s3-fetch[2.41.1]     9.4854 (1.23)     9.4854 (1.23)     9.4854 (1.23)     0.0000 (1.0)      9.4854 (1.23)     0.0000 (1.0)           0;0  0.1054 (0.81)          1           1
test_sharing_s3-fetch[2.45.0]     7.6927 (1.0)      7.6927 (1.0)      7.6927 (1.0)      0.0000 (1.0)      7.6927 (1.0)      0.0000 (1.0)           0;0  0.1300 (1.0)           1           1
test_sharing_s3-fetch[main]       8.0414 (1.05)     8.0414 (1.05)     8.0414 (1.05)     0.0000 (1.0)      8.0414 (1.05)     0.0000 (1.0)           0;0  0.1244 (0.96)          1           1
--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------- benchmark 'test_sharing_s3-fetch-noop': 7 tests --------------------------------------------------------------------------------
Name (time in ms)                             Min                   Max                  Mean            StdDev                Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-fetch-noop[2.11.0]       486.4586 (1.0)        486.4586 (1.0)        486.4586 (1.0)      0.0000 (1.0)        486.4586 (1.0)      0.0000 (1.0)           0;0  2.0557 (1.0)           1           1
test_sharing_s3-fetch-noop[2.18.1]       490.6174 (1.01)       490.6174 (1.01)       490.6174 (1.01)     0.0000 (1.0)        490.6174 (1.01)     0.0000 (1.0)           0;0  2.0382 (0.99)          1           1
test_sharing_s3-fetch-noop[2.39.0]       510.9021 (1.05)       510.9021 (1.05)       510.9021 (1.05)     0.0000 (1.0)        510.9021 (1.05)     0.0000 (1.0)           0;0  1.9573 (0.95)          1           1
test_sharing_s3-fetch-noop[2.40.0]       525.8807 (1.08)       525.8807 (1.08)       525.8807 (1.08)     0.0000 (1.0)        525.8807 (1.08)     0.0000 (1.0)           0;0  1.9016 (0.93)          1           1
test_sharing_s3-fetch-noop[2.41.1]       516.9157 (1.06)       516.9157 (1.06)       516.9157 (1.06)     0.0000 (1.0)        516.9157 (1.06)     0.0000 (1.0)           0;0  1.9346 (0.94)          1           1
test_sharing_s3-fetch-noop[2.45.0]       530.1212 (1.09)       530.1212 (1.09)       530.1212 (1.09)     0.0000 (1.0)        530.1212 (1.09)     0.0000 (1.0)           0;0  1.8864 (0.92)          1           1
test_sharing_s3-fetch-noop[main]       1,132.3066 (2.33)     1,132.3066 (2.33)     1,132.3066 (2.33)     0.0000 (1.0)      1,132.3066 (2.33)     0.0000 (1.0)           0;0  0.8832 (0.43)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------- benchmark 'test_sharing_s3-push': 7 tests --------------------------------------------------------------------------
Name (time in s)                     Min                Max               Mean            StdDev             Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push[2.11.0]     21.4284 (2.72)     21.4284 (2.72)     21.4284 (2.72)     0.0000 (1.0)      21.4284 (2.72)     0.0000 (1.0)           0;0  0.0467 (0.37)          1           1
test_sharing_s3-push[2.18.1]     21.3255 (2.71)     21.3255 (2.71)     21.3255 (2.71)     0.0000 (1.0)      21.3255 (2.71)     0.0000 (1.0)           0;0  0.0469 (0.37)          1           1
test_sharing_s3-push[2.39.0]     21.4375 (2.72)     21.4375 (2.72)     21.4375 (2.72)     0.0000 (1.0)      21.4375 (2.72)     0.0000 (1.0)           0;0  0.0466 (0.37)          1           1
test_sharing_s3-push[2.40.0]     21.6965 (2.76)     21.6965 (2.76)     21.6965 (2.76)     0.0000 (1.0)      21.6965 (2.76)     0.0000 (1.0)           0;0  0.0461 (0.36)          1           1
test_sharing_s3-push[2.41.1]      8.8314 (1.12)      8.8314 (1.12)      8.8314 (1.12)     0.0000 (1.0)       8.8314 (1.12)     0.0000 (1.0)           0;0  0.1132 (0.89)          1           1
test_sharing_s3-push[2.45.0]      7.8747 (1.0)       7.8747 (1.0)       7.8747 (1.0)      0.0000 (1.0)       7.8747 (1.0)      0.0000 (1.0)           0;0  0.1270 (1.0)           1           1
test_sharing_s3-push[main]        8.5108 (1.08)      8.5108 (1.08)      8.5108 (1.08)     0.0000 (1.0)       8.5108 (1.08)     0.0000 (1.0)           0;0  0.1175 (0.93)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------- benchmark 'test_sharing_s3-push-noop': 7 tests --------------------------------------------------------------------------------
Name (time in ms)                            Min                   Max                  Mean            StdDev                Median               IQR            Outliers     OPS            Rounds  Iterations
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push-noop[2.11.0]       673.6751 (1.05)       673.6751 (1.05)       673.6751 (1.05)     0.0000 (1.0)        673.6751 (1.05)     0.0000 (1.0)           0;0  1.4844 (0.95)          1           1
test_sharing_s3-push-noop[2.18.1]       642.5247 (1.0)        642.5247 (1.0)        642.5247 (1.0)      0.0000 (1.0)        642.5247 (1.0)      0.0000 (1.0)           0;0  1.5564 (1.0)           1           1
test_sharing_s3-push-noop[2.39.0]       686.3961 (1.07)       686.3961 (1.07)       686.3961 (1.07)     0.0000 (1.0)        686.3961 (1.07)     0.0000 (1.0)           0;0  1.4569 (0.94)          1           1
test_sharing_s3-push-noop[2.40.0]       698.4248 (1.09)       698.4248 (1.09)       698.4248 (1.09)     0.0000 (1.0)        698.4248 (1.09)     0.0000 (1.0)           0;0  1.4318 (0.92)          1           1
test_sharing_s3-push-noop[2.41.1]       662.5527 (1.03)       662.5527 (1.03)       662.5527 (1.03)     0.0000 (1.0)        662.5527 (1.03)     0.0000 (1.0)           0;0  1.5093 (0.97)          1           1
test_sharing_s3-push-noop[2.45.0]       665.2829 (1.04)       665.2829 (1.04)       665.2829 (1.04)     0.0000 (1.0)        665.2829 (1.04)     0.0000 (1.0)           0;0  1.5031 (0.97)          1           1
test_sharing_s3-push-noop[main]       1,110.0554 (1.73)     1,110.0554 (1.73)     1,110.0554 (1.73)     0.0000 (1.0)      1,110.0554 (1.73)     0.0000 (1.0)           0;0  0.9009 (0.58)          1           1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@skshetry skshetry merged commit 16016c7 into main Mar 1, 2024
10 checks passed
@skshetry skshetry deleted the load-dvc-testing-plugin branch March 1, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@skshetry