Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump minver of s3fs to 2023.6.0 #44

Merged
merged 3 commits into from
Jun 13, 2023
Merged

deps: bump minver of s3fs to 2023.6.0 #44

merged 3 commits into from
Jun 13, 2023

Conversation

skshetry
Copy link
Member

@skshetry skshetry commented Jun 13, 2023

So that we require aiobotocore>=2.5.0.

@efiop
Copy link
Contributor

efiop commented Jun 13, 2023

We've actually merged some fixes in the latest s3fs for cloud versioning. Can we bump it all the way to 6.0?

setup.cfg Outdated Show resolved Hide resolved
@skshetry skshetry changed the title deps: bump minver of s3fs to 2023.4.0 deps: bump minver of s3fs to 2023.6.0 Jun 13, 2023
@skshetry skshetry merged commit a2bdc30 into main Jun 13, 2023
@skshetry skshetry deleted the skshetry-patch-1 branch June 13, 2023 09:39
@github-actions
Copy link
Contributor


------------------------------------------------------------------------ benchmark 'test_sharing_s3-add': 7 tests ------------------------------------------------------------------------
Name (time in s)                   Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add[2.11.0]     6.4812 (1.58)     6.4812 (1.58)     6.4812 (1.58)     0.0000 (1.0)      6.4812 (1.58)     0.0000 (1.0)           0;0  0.1543 (0.63)          1           1
test_sharing_s3-add[2.18.1]     5.2884 (1.29)     5.2884 (1.29)     5.2884 (1.29)     0.0000 (1.0)      5.2884 (1.29)     0.0000 (1.0)           0;0  0.1891 (0.78)          1           1
test_sharing_s3-add[2.39.0]     5.0968 (1.24)     5.0968 (1.24)     5.0968 (1.24)     0.0000 (1.0)      5.0968 (1.24)     0.0000 (1.0)           0;0  0.1962 (0.81)          1           1
test_sharing_s3-add[2.40.0]     5.6477 (1.37)     5.6477 (1.37)     5.6477 (1.37)     0.0000 (1.0)      5.6477 (1.37)     0.0000 (1.0)           0;0  0.1771 (0.73)          1           1
test_sharing_s3-add[2.41.1]     5.1942 (1.26)     5.1942 (1.26)     5.1942 (1.26)     0.0000 (1.0)      5.1942 (1.26)     0.0000 (1.0)           0;0  0.1925 (0.79)          1           1
test_sharing_s3-add[2.45.0]     4.1137 (1.0)      4.1137 (1.0)      4.1137 (1.0)      0.0000 (1.0)      4.1137 (1.0)      0.0000 (1.0)           0;0  0.2431 (1.0)           1           1
test_sharing_s3-add[main]       4.1906 (1.02)     4.1906 (1.02)     4.1906 (1.02)     0.0000 (1.0)      4.1906 (1.02)     0.0000 (1.0)           0;0  0.2386 (0.98)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-add-noop': 7 tests ------------------------------------------------------------------------
Name (time in s)                        Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add-noop[2.11.0]     2.5323 (1.0)      2.5323 (1.0)      2.5323 (1.0)      0.0000 (1.0)      2.5323 (1.0)      0.0000 (1.0)           0;0  0.3949 (1.0)           1           1
test_sharing_s3-add-noop[2.18.1]     2.7531 (1.09)     2.7531 (1.09)     2.7531 (1.09)     0.0000 (1.0)      2.7531 (1.09)     0.0000 (1.0)           0;0  0.3632 (0.92)          1           1
test_sharing_s3-add-noop[2.39.0]     2.5772 (1.02)     2.5772 (1.02)     2.5772 (1.02)     0.0000 (1.0)      2.5772 (1.02)     0.0000 (1.0)           0;0  0.3880 (0.98)          1           1
test_sharing_s3-add-noop[2.40.0]     2.5978 (1.03)     2.5978 (1.03)     2.5978 (1.03)     0.0000 (1.0)      2.5978 (1.03)     0.0000 (1.0)           0;0  0.3849 (0.97)          1           1
test_sharing_s3-add-noop[2.41.1]     2.5523 (1.01)     2.5523 (1.01)     2.5523 (1.01)     0.0000 (1.0)      2.5523 (1.01)     0.0000 (1.0)           0;0  0.3918 (0.99)          1           1
test_sharing_s3-add-noop[2.45.0]     2.7558 (1.09)     2.7558 (1.09)     2.7558 (1.09)     0.0000 (1.0)      2.7558 (1.09)     0.0000 (1.0)           0;0  0.3629 (0.92)          1           1
test_sharing_s3-add-noop[main]       2.8120 (1.11)     2.8120 (1.11)     2.8120 (1.11)     0.0000 (1.0)      2.8120 (1.11)     0.0000 (1.0)           0;0  0.3556 (0.90)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_s3-checkout-noop': 7 tests ----------------------------------------------------------------------------
Name (time in ms)                              Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-checkout-noop[2.11.0]     536.4273 (1.0)      536.4273 (1.0)      536.4273 (1.0)      0.0000 (1.0)      536.4273 (1.0)      0.0000 (1.0)           0;0  1.8642 (1.0)           1           1
test_sharing_s3-checkout-noop[2.18.1]     607.5233 (1.13)     607.5233 (1.13)     607.5233 (1.13)     0.0000 (1.0)      607.5233 (1.13)     0.0000 (1.0)           0;0  1.6460 (0.88)          1           1
test_sharing_s3-checkout-noop[2.39.0]     638.9397 (1.19)     638.9397 (1.19)     638.9397 (1.19)     0.0000 (1.0)      638.9397 (1.19)     0.0000 (1.0)           0;0  1.5651 (0.84)          1           1
test_sharing_s3-checkout-noop[2.40.0]     620.4372 (1.16)     620.4372 (1.16)     620.4372 (1.16)     0.0000 (1.0)      620.4372 (1.16)     0.0000 (1.0)           0;0  1.6118 (0.86)          1           1
test_sharing_s3-checkout-noop[2.41.1]     617.9437 (1.15)     617.9437 (1.15)     617.9437 (1.15)     0.0000 (1.0)      617.9437 (1.15)     0.0000 (1.0)           0;0  1.6183 (0.87)          1           1
test_sharing_s3-checkout-noop[2.45.0]     634.0081 (1.18)     634.0081 (1.18)     634.0081 (1.18)     0.0000 (1.0)      634.0081 (1.18)     0.0000 (1.0)           0;0  1.5773 (0.85)          1           1
test_sharing_s3-checkout-noop[main]       984.9691 (1.84)     984.9691 (1.84)     984.9691 (1.84)     0.0000 (1.0)      984.9691 (1.84)     0.0000 (1.0)           0;0  1.0153 (0.54)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------- benchmark 'test_sharing_s3-pull': 7 tests --------------------------------------------------------------------------
Name (time in s)                     Min                Max               Mean            StdDev             Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-pull[2.11.0]     12.5096 (1.19)     12.5096 (1.19)     12.5096 (1.19)     0.0000 (1.0)      12.5096 (1.19)     0.0000 (1.0)           0;0  0.0799 (0.84)          1           1
test_sharing_s3-pull[2.18.1]     14.2109 (1.35)     14.2109 (1.35)     14.2109 (1.35)     0.0000 (1.0)      14.2109 (1.35)     0.0000 (1.0)           0;0  0.0704 (0.74)          1           1
test_sharing_s3-pull[2.39.0]     13.2968 (1.27)     13.2968 (1.27)     13.2968 (1.27)     0.0000 (1.0)      13.2968 (1.27)     0.0000 (1.0)           0;0  0.0752 (0.79)          1           1
test_sharing_s3-pull[2.40.0]     13.0628 (1.24)     13.0628 (1.24)     13.0628 (1.24)     0.0000 (1.0)      13.0628 (1.24)     0.0000 (1.0)           0;0  0.0766 (0.80)          1           1
test_sharing_s3-pull[2.41.1]     12.5451 (1.19)     12.5451 (1.19)     12.5451 (1.19)     0.0000 (1.0)      12.5451 (1.19)     0.0000 (1.0)           0;0  0.0797 (0.84)          1           1
test_sharing_s3-pull[2.45.0]     11.1834 (1.07)     11.1834 (1.07)     11.1834 (1.07)     0.0000 (1.0)      11.1834 (1.07)     0.0000 (1.0)           0;0  0.0894 (0.94)          1           1
test_sharing_s3-pull[main]       10.5004 (1.0)      10.5004 (1.0)      10.5004 (1.0)      0.0000 (1.0)      10.5004 (1.0)      0.0000 (1.0)           0;0  0.0952 (1.0)           1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------- benchmark 'test_sharing_s3-pull-noop': 7 tests --------------------------------------------------------------------------------
Name (time in ms)                            Min                   Max                  Mean            StdDev                Median               IQR            Outliers     OPS            Rounds  Iterations
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-pull-noop[2.11.0]       787.2048 (1.0)        787.2048 (1.0)        787.2048 (1.0)      0.0000 (1.0)        787.2048 (1.0)      0.0000 (1.0)           0;0  1.2703 (1.0)           1           1
test_sharing_s3-pull-noop[2.18.1]       862.3652 (1.10)       862.3652 (1.10)       862.3652 (1.10)     0.0000 (1.0)        862.3652 (1.10)     0.0000 (1.0)           0;0  1.1596 (0.91)          1           1
test_sharing_s3-pull-noop[2.39.0]       892.8723 (1.13)       892.8723 (1.13)       892.8723 (1.13)     0.0000 (1.0)        892.8723 (1.13)     0.0000 (1.0)           0;0  1.1200 (0.88)          1           1
test_sharing_s3-pull-noop[2.40.0]       861.2574 (1.09)       861.2574 (1.09)       861.2574 (1.09)     0.0000 (1.0)        861.2574 (1.09)     0.0000 (1.0)           0;0  1.1611 (0.91)          1           1
test_sharing_s3-pull-noop[2.41.1]       855.9831 (1.09)       855.9831 (1.09)       855.9831 (1.09)     0.0000 (1.0)        855.9831 (1.09)     0.0000 (1.0)           0;0  1.1682 (0.92)          1           1
test_sharing_s3-pull-noop[2.45.0]       888.9824 (1.13)       888.9824 (1.13)       888.9824 (1.13)     0.0000 (1.0)        888.9824 (1.13)     0.0000 (1.0)           0;0  1.1249 (0.89)          1           1
test_sharing_s3-pull-noop[main]       1,154.5390 (1.47)     1,154.5390 (1.47)     1,154.5390 (1.47)     0.0000 (1.0)      1,154.5390 (1.47)     0.0000 (1.0)           0;0  0.8661 (0.68)          1           1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------- benchmark 'test_sharing_s3-push': 7 tests --------------------------------------------------------------------------
Name (time in s)                     Min                Max               Mean            StdDev             Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push[2.11.0]     22.7056 (2.69)     22.7056 (2.69)     22.7056 (2.69)     0.0000 (1.0)      22.7056 (2.69)     0.0000 (1.0)           0;0  0.0440 (0.37)          1           1
test_sharing_s3-push[2.18.1]     23.4063 (2.77)     23.4063 (2.77)     23.4063 (2.77)     0.0000 (1.0)      23.4063 (2.77)     0.0000 (1.0)           0;0  0.0427 (0.36)          1           1
test_sharing_s3-push[2.39.0]     22.2458 (2.64)     22.2458 (2.64)     22.2458 (2.64)     0.0000 (1.0)      22.2458 (2.64)     0.0000 (1.0)           0;0  0.0450 (0.38)          1           1
test_sharing_s3-push[2.40.0]     22.4112 (2.65)     22.4112 (2.65)     22.4112 (2.65)     0.0000 (1.0)      22.4112 (2.65)     0.0000 (1.0)           0;0  0.0446 (0.38)          1           1
test_sharing_s3-push[2.41.1]     10.0312 (1.19)     10.0312 (1.19)     10.0312 (1.19)     0.0000 (1.0)      10.0312 (1.19)     0.0000 (1.0)           0;0  0.0997 (0.84)          1           1
test_sharing_s3-push[2.45.0]      9.2141 (1.09)      9.2141 (1.09)      9.2141 (1.09)     0.0000 (1.0)       9.2141 (1.09)     0.0000 (1.0)           0;0  0.1085 (0.92)          1           1
test_sharing_s3-push[main]        8.4413 (1.0)       8.4413 (1.0)       8.4413 (1.0)      0.0000 (1.0)       8.4413 (1.0)      0.0000 (1.0)           0;0  0.1185 (1.0)           1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-push-noop': 7 tests ------------------------------------------------------------------------
Name (time in s)                         Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push-noop[2.11.0]     1.0354 (1.0)      1.0354 (1.0)      1.0354 (1.0)      0.0000 (1.0)      1.0354 (1.0)      0.0000 (1.0)           0;0  0.9658 (1.0)           1           1
test_sharing_s3-push-noop[2.18.1]     1.0811 (1.04)     1.0811 (1.04)     1.0811 (1.04)     0.0000 (1.0)      1.0811 (1.04)     0.0000 (1.0)           0;0  0.9250 (0.96)          1           1
test_sharing_s3-push-noop[2.39.0]     1.0999 (1.06)     1.0999 (1.06)     1.0999 (1.06)     0.0000 (1.0)      1.0999 (1.06)     0.0000 (1.0)           0;0  0.9092 (0.94)          1           1
test_sharing_s3-push-noop[2.40.0]     1.1196 (1.08)     1.1196 (1.08)     1.1196 (1.08)     0.0000 (1.0)      1.1196 (1.08)     0.0000 (1.0)           0;0  0.8932 (0.92)          1           1
test_sharing_s3-push-noop[2.41.1]     1.0740 (1.04)     1.0740 (1.04)     1.0740 (1.04)     0.0000 (1.0)      1.0740 (1.04)     0.0000 (1.0)           0;0  0.9311 (0.96)          1           1
test_sharing_s3-push-noop[2.45.0]     1.1364 (1.10)     1.1364 (1.10)     1.1364 (1.10)     0.0000 (1.0)      1.1364 (1.10)     0.0000 (1.0)           0;0  0.8800 (0.91)          1           1
test_sharing_s3-push-noop[main]       1.1427 (1.10)     1.1427 (1.10)     1.1427 (1.10)     0.0000 (1.0)      1.1427 (1.10)     0.0000 (1.0)           0;0  0.8751 (0.91)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants