Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use real S3 when DVC_TEST_AWS_REPO_BUCKET is set #40

Merged
merged 2 commits into from
May 5, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented May 5, 2023

previous configuration was to use a separate real_s3 fixture, but what we really want is for the standard remote/cloud/s3 fixture workflow to decide whether to use moto or real S3 based on the environment (so we don't have to define separate tests for real vs fake s3)

@pmrowla pmrowla self-assigned this May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023


------------------------------------------------------------------------ benchmark 'test_sharing_s3-add': 7 tests ------------------------------------------------------------------------
Name (time in s)                   Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add[2.11.0]     9.5021 (1.68)     9.5021 (1.68)     9.5021 (1.68)     0.0000 (1.0)      9.5021 (1.68)     0.0000 (1.0)           0;0  0.1052 (0.60)          1           1
test_sharing_s3-add[2.18.1]     7.9870 (1.41)     7.9870 (1.41)     7.9870 (1.41)     0.0000 (1.0)      7.9870 (1.41)     0.0000 (1.0)           0;0  0.1252 (0.71)          1           1
test_sharing_s3-add[2.39.0]     7.5606 (1.34)     7.5606 (1.34)     7.5606 (1.34)     0.0000 (1.0)      7.5606 (1.34)     0.0000 (1.0)           0;0  0.1323 (0.75)          1           1
test_sharing_s3-add[2.40.0]     7.9469 (1.40)     7.9469 (1.40)     7.9469 (1.40)     0.0000 (1.0)      7.9469 (1.40)     0.0000 (1.0)           0;0  0.1258 (0.71)          1           1
test_sharing_s3-add[2.41.1]     8.0576 (1.42)     8.0576 (1.42)     8.0576 (1.42)     0.0000 (1.0)      8.0576 (1.42)     0.0000 (1.0)           0;0  0.1241 (0.70)          1           1
test_sharing_s3-add[2.45.0]     5.6580 (1.00)     5.6580 (1.00)     5.6580 (1.00)     0.0000 (1.0)      5.6580 (1.00)     0.0000 (1.0)           0;0  0.1767 (1.00)          1           1
test_sharing_s3-add[main]       5.6563 (1.0)      5.6563 (1.0)      5.6563 (1.0)      0.0000 (1.0)      5.6563 (1.0)      0.0000 (1.0)           0;0  0.1768 (1.0)           1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-add-noop': 7 tests ------------------------------------------------------------------------
Name (time in s)                        Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-add-noop[2.11.0]     3.5277 (1.0)      3.5277 (1.0)      3.5277 (1.0)      0.0000 (1.0)      3.5277 (1.0)      0.0000 (1.0)           0;0  0.2835 (1.0)           1           1
test_sharing_s3-add-noop[2.18.1]     3.9491 (1.12)     3.9491 (1.12)     3.9491 (1.12)     0.0000 (1.0)      3.9491 (1.12)     0.0000 (1.0)           0;0  0.2532 (0.89)          1           1
test_sharing_s3-add-noop[2.39.0]     3.5873 (1.02)     3.5873 (1.02)     3.5873 (1.02)     0.0000 (1.0)      3.5873 (1.02)     0.0000 (1.0)           0;0  0.2788 (0.98)          1           1
test_sharing_s3-add-noop[2.40.0]     3.6513 (1.04)     3.6513 (1.04)     3.6513 (1.04)     0.0000 (1.0)      3.6513 (1.04)     0.0000 (1.0)           0;0  0.2739 (0.97)          1           1
test_sharing_s3-add-noop[2.41.1]     3.6516 (1.04)     3.6516 (1.04)     3.6516 (1.04)     0.0000 (1.0)      3.6516 (1.04)     0.0000 (1.0)           0;0  0.2738 (0.97)          1           1
test_sharing_s3-add-noop[2.45.0]     3.7361 (1.06)     3.7361 (1.06)     3.7361 (1.06)     0.0000 (1.0)      3.7361 (1.06)     0.0000 (1.0)           0;0  0.2677 (0.94)          1           1
test_sharing_s3-add-noop[main]       3.8253 (1.08)     3.8253 (1.08)     3.8253 (1.08)     0.0000 (1.0)      3.8253 (1.08)     0.0000 (1.0)           0;0  0.2614 (0.92)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

---------------------------------------------------------------------------- benchmark 'test_sharing_s3-checkout-noop': 7 tests ----------------------------------------------------------------------------
Name (time in ms)                              Min                 Max                Mean            StdDev              Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-checkout-noop[2.11.0]     644.6388 (1.0)      644.6388 (1.0)      644.6388 (1.0)      0.0000 (1.0)      644.6388 (1.0)      0.0000 (1.0)           0;0  1.5513 (1.0)           1           1
test_sharing_s3-checkout-noop[2.18.1]     817.9999 (1.27)     817.9999 (1.27)     817.9999 (1.27)     0.0000 (1.0)      817.9999 (1.27)     0.0000 (1.0)           0;0  1.2225 (0.79)          1           1
test_sharing_s3-checkout-noop[2.39.0]     844.6003 (1.31)     844.6003 (1.31)     844.6003 (1.31)     0.0000 (1.0)      844.6003 (1.31)     0.0000 (1.0)           0;0  1.1840 (0.76)          1           1
test_sharing_s3-checkout-noop[2.40.0]     806.7114 (1.25)     806.7114 (1.25)     806.7114 (1.25)     0.0000 (1.0)      806.7114 (1.25)     0.0000 (1.0)           0;0  1.2396 (0.80)          1           1
test_sharing_s3-checkout-noop[2.41.1]     902.3848 (1.40)     902.3848 (1.40)     902.3848 (1.40)     0.0000 (1.0)      902.3848 (1.40)     0.0000 (1.0)           0;0  1.1082 (0.71)          1           1
test_sharing_s3-checkout-noop[2.45.0]     841.9975 (1.31)     841.9975 (1.31)     841.9975 (1.31)     0.0000 (1.0)      841.9975 (1.31)     0.0000 (1.0)           0;0  1.1877 (0.77)          1           1
test_sharing_s3-checkout-noop[main]       949.6995 (1.47)     949.6995 (1.47)     949.6995 (1.47)     0.0000 (1.0)      949.6995 (1.47)     0.0000 (1.0)           0;0  1.0530 (0.68)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------- benchmark 'test_sharing_s3-pull': 7 tests --------------------------------------------------------------------------
Name (time in s)                     Min                Max               Mean            StdDev             Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-pull[2.11.0]     17.5607 (1.26)     17.5607 (1.26)     17.5607 (1.26)     0.0000 (1.0)      17.5607 (1.26)     0.0000 (1.0)           0;0  0.0569 (0.79)          1           1
test_sharing_s3-pull[2.18.1]     17.8662 (1.28)     17.8662 (1.28)     17.8662 (1.28)     0.0000 (1.0)      17.8662 (1.28)     0.0000 (1.0)           0;0  0.0560 (0.78)          1           1
test_sharing_s3-pull[2.39.0]     16.8471 (1.21)     16.8471 (1.21)     16.8471 (1.21)     0.0000 (1.0)      16.8471 (1.21)     0.0000 (1.0)           0;0  0.0594 (0.83)          1           1
test_sharing_s3-pull[2.40.0]     16.2911 (1.17)     16.2911 (1.17)     16.2911 (1.17)     0.0000 (1.0)      16.2911 (1.17)     0.0000 (1.0)           0;0  0.0614 (0.85)          1           1
test_sharing_s3-pull[2.41.1]     16.9700 (1.22)     16.9700 (1.22)     16.9700 (1.22)     0.0000 (1.0)      16.9700 (1.22)     0.0000 (1.0)           0;0  0.0589 (0.82)          1           1
test_sharing_s3-pull[2.45.0]     13.9227 (1.0)      13.9227 (1.0)      13.9227 (1.0)      0.0000 (1.0)      13.9227 (1.0)      0.0000 (1.0)           0;0  0.0718 (1.0)           1           1
test_sharing_s3-pull[main]       13.9321 (1.00)     13.9321 (1.00)     13.9321 (1.00)     0.0000 (1.0)      13.9321 (1.00)     0.0000 (1.0)           0;0  0.0718 (1.00)          1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------------- benchmark 'test_sharing_s3-pull-noop': 7 tests --------------------------------------------------------------------------------
Name (time in ms)                            Min                   Max                  Mean            StdDev                Median               IQR            Outliers     OPS            Rounds  Iterations
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-pull-noop[2.11.0]       940.0248 (1.0)        940.0248 (1.0)        940.0248 (1.0)      0.0000 (1.0)        940.0248 (1.0)      0.0000 (1.0)           0;0  1.0638 (1.0)           1           1
test_sharing_s3-pull-noop[2.18.1]     1,147.5311 (1.22)     1,147.5311 (1.22)     1,147.5311 (1.22)     0.0000 (1.0)      1,147.5311 (1.22)     0.0000 (1.0)           0;0  0.8714 (0.82)          1           1
test_sharing_s3-pull-noop[2.39.0]     1,116.8734 (1.19)     1,116.8734 (1.19)     1,116.8734 (1.19)     0.0000 (1.0)      1,116.8734 (1.19)     0.0000 (1.0)           0;0  0.8954 (0.84)          1           1
test_sharing_s3-pull-noop[2.40.0]     1,126.9833 (1.20)     1,126.9833 (1.20)     1,126.9833 (1.20)     0.0000 (1.0)      1,126.9833 (1.20)     0.0000 (1.0)           0;0  0.8873 (0.83)          1           1
test_sharing_s3-pull-noop[2.41.1]     1,140.5865 (1.21)     1,140.5865 (1.21)     1,140.5865 (1.21)     0.0000 (1.0)      1,140.5865 (1.21)     0.0000 (1.0)           0;0  0.8767 (0.82)          1           1
test_sharing_s3-pull-noop[2.45.0]     1,178.4215 (1.25)     1,178.4215 (1.25)     1,178.4215 (1.25)     0.0000 (1.0)      1,178.4215 (1.25)     0.0000 (1.0)           0;0  0.8486 (0.80)          1           1
test_sharing_s3-pull-noop[main]       1,214.2746 (1.29)     1,214.2746 (1.29)     1,214.2746 (1.29)     0.0000 (1.0)      1,214.2746 (1.29)     0.0000 (1.0)           0;0  0.8235 (0.77)          1           1
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

-------------------------------------------------------------------------- benchmark 'test_sharing_s3-push': 7 tests --------------------------------------------------------------------------
Name (time in s)                     Min                Max               Mean            StdDev             Median               IQR            Outliers     OPS            Rounds  Iterations
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push[2.11.0]     30.2140 (2.73)     30.2140 (2.73)     30.2140 (2.73)     0.0000 (1.0)      30.2140 (2.73)     0.0000 (1.0)           0;0  0.0331 (0.37)          1           1
test_sharing_s3-push[2.18.1]     29.7725 (2.69)     29.7725 (2.69)     29.7725 (2.69)     0.0000 (1.0)      29.7725 (2.69)     0.0000 (1.0)           0;0  0.0336 (0.37)          1           1
test_sharing_s3-push[2.39.0]     28.3045 (2.56)     28.3045 (2.56)     28.3045 (2.56)     0.0000 (1.0)      28.3045 (2.56)     0.0000 (1.0)           0;0  0.0353 (0.39)          1           1
test_sharing_s3-push[2.40.0]     28.6005 (2.58)     28.6005 (2.58)     28.6005 (2.58)     0.0000 (1.0)      28.6005 (2.58)     0.0000 (1.0)           0;0  0.0350 (0.39)          1           1
test_sharing_s3-push[2.41.1]     14.7267 (1.33)     14.7267 (1.33)     14.7267 (1.33)     0.0000 (1.0)      14.7267 (1.33)     0.0000 (1.0)           0;0  0.0679 (0.75)          1           1
test_sharing_s3-push[2.45.0]     11.2791 (1.02)     11.2791 (1.02)     11.2791 (1.02)     0.0000 (1.0)      11.2791 (1.02)     0.0000 (1.0)           0;0  0.0887 (0.98)          1           1
test_sharing_s3-push[main]       11.0756 (1.0)      11.0756 (1.0)      11.0756 (1.0)      0.0000 (1.0)      11.0756 (1.0)      0.0000 (1.0)           0;0  0.0903 (1.0)           1           1
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

------------------------------------------------------------------------ benchmark 'test_sharing_s3-push-noop': 7 tests ------------------------------------------------------------------------
Name (time in s)                         Min               Max              Mean            StdDev            Median               IQR            Outliers     OPS            Rounds  Iterations
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_sharing_s3-push-noop[2.11.0]     1.2939 (1.02)     1.2939 (1.02)     1.2939 (1.02)     0.0000 (1.0)      1.2939 (1.02)     0.0000 (1.0)           0;0  0.7728 (0.98)          1           1
test_sharing_s3-push-noop[2.18.1]     1.2641 (1.0)      1.2641 (1.0)      1.2641 (1.0)      0.0000 (1.0)      1.2641 (1.0)      0.0000 (1.0)           0;0  0.7911 (1.0)           1           1
test_sharing_s3-push-noop[2.39.0]     1.2711 (1.01)     1.2711 (1.01)     1.2711 (1.01)     0.0000 (1.0)      1.2711 (1.01)     0.0000 (1.0)           0;0  0.7867 (0.99)          1           1
test_sharing_s3-push-noop[2.40.0]     1.2726 (1.01)     1.2726 (1.01)     1.2726 (1.01)     0.0000 (1.0)      1.2726 (1.01)     0.0000 (1.0)           0;0  0.7858 (0.99)          1           1
test_sharing_s3-push-noop[2.41.1]     1.3756 (1.09)     1.3756 (1.09)     1.3756 (1.09)     0.0000 (1.0)      1.3756 (1.09)     0.0000 (1.0)           0;0  0.7270 (0.92)          1           1
test_sharing_s3-push-noop[2.45.0]     1.2664 (1.00)     1.2664 (1.00)     1.2664 (1.00)     0.0000 (1.0)      1.2664 (1.00)     0.0000 (1.0)           0;0  0.7897 (1.00)          1           1
test_sharing_s3-push-noop[main]       1.3464 (1.07)     1.3464 (1.07)     1.3464 (1.07)     0.0000 (1.0)      1.3464 (1.07)     0.0000 (1.0)           0;0  0.7427 (0.94)          1           1
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

Legend:
  Outliers: 1 Standard Deviation from Mean; 1.5 IQR (InterQuartile Range) from 1st Quartile and 3rd Quartile.
  OPS: Operations Per Second, computed as 1 / Mean

@pmrowla pmrowla merged commit 03530ea into main May 5, 2023
@skshetry skshetry deleted the tests-real-s3 branch March 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant