Fix: Ignore disabled clients in monitors when enabled #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twwd
requested changes
Dec 13, 2024
|
I have added tests for the ServiceAccountWithSensitiveRole monitor, but should probably take this opportunity to add tests for the other four monitors as well. So, please hold off on merging for now. |
|
Added test cases for all monitors now. Should probably go back and rewrite some of the older test cases with the techniques I learned now, but if I do that, we will never merge this 😁. |
twwd
force-pushed
the
feature/ignore_disabled_clients_in_monitors
branch
from
a143e7b to
8b12197
Compare
twwd
approved these changes
Jan 9, 2025
twwd
force-pushed
the
feature/ignore_disabled_clients_in_monitors
branch
from
8b12197 to
e1cd0f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the monitors did not respect the
--ignore-disabled-clientsswitch. This PR fixes that issue and closes #46 (or, to be exact, its more general case, as that issue only refers to one of the three affected monitors).