Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Auto-import auditors #43

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Refactoring: Auto-import auditors #43

merged 2 commits into from
Oct 8, 2024

Conversation

twwd
Copy link
Collaborator

@twwd twwd commented Oct 2, 2024

Use automatic importing for collecting built-in auditors and monitors. Therefore, monitors are moved into separate packages per entity.

In addition, I've got rid of the class attributes for the Keycloak objects that are used as instance attributes.

Closes #25

@twwd twwd requested a review from malexmave October 2, 2024 14:16
@twwd twwd force-pushed the 25-refactorings branch from f8b53c0 to 75d9121 Compare October 7, 2024 06:52
Copy link
Collaborator

@malexmave malexmave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks :)

@malexmave malexmave added the enhancement New feature or request label Oct 8, 2024
twwd added 2 commits October 8, 2024 10:25
Therefore, monitors are moved into separate packages per entity.

Signed-off-by: Tim Walter <[email protected]>
@twwd twwd force-pushed the 25-refactorings branch from 75d9121 to 869fc82 Compare October 8, 2024 08:26
@twwd twwd enabled auto-merge (rebase) October 8, 2024 08:26
@twwd twwd merged commit 4f8aa9e into main Oct 8, 2024
3 checks passed
@twwd twwd deleted the 25-refactorings branch October 8, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: Auto-import auditors from sub-packages
2 participants