Python 3.3 support #10
Conversation
| from eliot import tai64n | ||
|
|
||
| if PY3: | ||
| from eliot import _py3json as json |
There was a problem hiding this comment.
I thought the convention was to use explicit relative imports.
| pyjson = json | ||
| else: | ||
| try: | ||
| # ujson is pretty crappy... but much faster than built-in json module, at |
There was a problem hiding this comment.
Not really related to this branch specifically, but I guess it might be nice not to say things like "ujson is pretty crappy" (now that this comment is public :). Perhaps it even would have been good if this comment had been more specific to begin with because right now I'm trying to remember what we don't like about ujson. Maybe it skips a bunch of error handling and generates garbage output for garbage input?
|
Only fairly minor comments from me... I'm just relying on travis to know if this actually makes it work or not (and travis says it does). I think the comment about ujson and the skip messages are worth fixing. The rest is up to you. Address and merge at your discretion. Thanks! |
Python 3.3 support. Fixes #1.
Fixes #1, in theory.