Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue141 - Become agnostic to logging implementation #142

Merged
merged 3 commits into from
Jan 10, 2020

Conversation

isuPatches
Copy link
Owner

closes #141

@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #142 into develop will decrease coverage by 4.44%.
The diff coverage is 26.76%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #142      +/-   ##
=============================================
- Coverage      94.32%   89.88%   -4.45%     
+ Complexity       600      579      -21     
=============================================
  Files             53       52       -1     
  Lines           1446     1434      -12     
  Branches         244      268      +24     
=============================================
- Hits            1364     1289      -75     
- Misses            35       75      +40     
- Partials          47       70      +23
Impacted Files Coverage Δ Complexity Δ
...isefysample/internal/logging/WiseFySampleLogger.kt 0% <0%> (ø) 0 <0> (?)
...ches/wisefy/connection/AbstractWiseFyConnection.kt 66.66% <0%> (-29.63%) 14 <2> (-1)
...m/isupatches/wisefy/search/AbstractWiseFySearch.kt 80.35% <0%> (-19.65%) 68 <3> (-1)
.../com/isupatches/wisefy/search/WiseFySearchSDK23.kt 100% <100%> (ø) 1 <0> (ø) ⬇️
...com/isupatches/wisefy/search/WiseFySearchLegacy.kt 100% <100%> (ø) 1 <0> (ø) ⬇️
...patches/wisefy/connection/WiseFyConnectionSDK23.kt 80.85% <33.33%> (-19.15%) 27 <0> (ø)
...sefy/src/main/java/com/isupatches/wisefy/WiseFy.kt 93.31% <43.75%> (-3.93%) 135 <0> (-1)
...atches/wisefy/connection/WiseFyConnectionLegacy.kt 93.33% <75%> (-6.67%) 17 <0> (-1)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f616a2...610432f. Read the comment docs.

@isuPatches isuPatches merged commit 3897eed into develop Jan 10, 2020
@isuPatches isuPatches deleted the issue141-become-logging-implementation-agnostic branch January 10, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logger and allow clients to provide an implementation
1 participant