Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue138 update dependencies and to gradle6 #140

Merged
merged 9 commits into from
Jan 8, 2020

Conversation

isuPatches
Copy link
Owner

@isuPatches isuPatches commented Jan 5, 2020

closes #138

@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #140 into 4.x will increase coverage by 0.12%.
The diff coverage is 96.39%.

Impacted file tree graph

@@             Coverage Diff             @@
##               4.x     #140      +/-   ##
===========================================
+ Coverage     94.2%   94.32%   +0.12%     
+ Complexity     682      600      -82     
===========================================
  Files           53       53              
  Lines         1501     1446      -55     
  Branches       253      244       -9     
===========================================
- Hits          1414     1364      -50     
+ Misses          41       35       -6     
- Partials        46       47       +1
Impacted Files Coverage Δ Complexity Δ
...m/isupatches/wisefysample/internal/util/SdkUtil.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...isefysample/ui/dialogs/BaseNoticeDialogFragment.kt 100% <ø> (ø) 3 <0> (ø) ⬇️
...s/wisefysample/internal/preferences/SearchStore.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
...patches/wisefysample/internal/base/BaseActivity.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...isupatches/wisefysample/internal/nav/MainRouter.kt 62.5% <ø> (ø) 0 <0> (ø) ⬇️
...ample/ui/dialogs/FullScreenNoticeDialogFragment.kt 70% <ø> (ø) 4 <0> (ø) ⬇️
.../isupatches/wisefysample/ui/add/AddNetworkModel.kt 100% <ø> (ø) 4 <0> (ø) ⬇️
...a/com/isupatches/wisefysample/ui/misc/MiscModel.kt 100% <ø> (ø) 9 <0> (ø) ⬇️
...patches/wisefysample/internal/util/KeyboardUtil.kt 66.66% <ø> (ø) 0 <0> (ø) ⬇️
...ysample/internal/preferences/RemoveNetworkStore.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc056a2...c08850b. Read the comment docs.

@isuPatches isuPatches added 4.x and removed 4.x labels Jan 8, 2020
@isuPatches isuPatches modified the milestone: 4.1.0 Jan 8, 2020
@isuPatches isuPatches merged commit 8f616a2 into 4.x Jan 8, 2020
@isuPatches isuPatches deleted the issue138-update-dependencies-and-to-gradle6 branch January 8, 2020 04:55
isuPatches added a commit that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies and to gradle 6+
1 participant