Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue119, issue120, issue122, issue124, and issue125 - Initial 4.x work #121

Merged
merged 7 commits into from
Apr 22, 2019

Conversation

isuPatches
Copy link
Owner

@isuPatches isuPatches commented Apr 21, 2019

closes #119
closes #120
closes #122
closes #124
closes #125

@isuPatches isuPatches changed the title issue119 - Update Gradle and dependencies issue119, issue1210 & issue122 - Update deps, update to AndroidX, and remove GCM hack Apr 21, 2019
@isuPatches isuPatches changed the title issue119, issue1210 & issue122 - Update deps, update to AndroidX, and remove GCM hack issue119, issue120, & issue122 - Update gralde, update deps, update to AndroidX, and remove GCM hack Apr 21, 2019
@codecov
Copy link

codecov bot commented Apr 21, 2019

Codecov Report

Merging #121 into 4.x will increase coverage by 4.02%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #121      +/-   ##
============================================
+ Coverage     90.98%   95.01%   +4.02%     
- Complexity      152      154       +2     
============================================
  Files            11       11              
  Lines           677      682       +5     
  Branches        219      192      -27     
============================================
+ Hits            616      648      +32     
  Misses            5        5              
+ Partials         56       29      -27
Impacted Files Coverage Δ Complexity Δ
...main/java/com/isupatches/wisefy/WiseFyPrechecks.kt 91.48% <ø> (+0.37%) 0 <0> (ø) ⬇️
...sefy/src/main/java/com/isupatches/wisefy/WiseFy.kt 97.83% <ø> (+6.25%) 134 <0> (ø) ⬇️
...rc/main/java/com/isupatches/wisefy/WiseFySearch.kt 96.33% <0%> (+0.03%) 0 <0> (ø) ⬇️
...ain/java/com/isupatches/wisefy/WiseFyConnection.kt 86.2% <100%> (+4.06%) 0 <0> (ø) ⬇️
...tches/wisefy/logging/WiseFyLoggerImplementation.kt 72.22% <0%> (+1.63%) 9% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9f9c4...a530409. Read the comment docs.

@isuPatches isuPatches changed the title issue119, issue120, & issue122 - Update gralde, update deps, update to AndroidX, and remove GCM hack issue119, issue120, issue122, issue124, and issue125 - Initial 4.x work Apr 22, 2019
@isuPatches isuPatches merged commit dcbad2c into 4.x Apr 22, 2019
@isuPatches isuPatches deleted the issue119-update-gradle-and-dependencies branch April 22, 2019 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant