Skip to content

[release-1.29] Add x forwarded network header#1736

Merged
istio-testing merged 1 commit intoistio:release-1.29from
keithmattix:1-29-x-forwarded-network
Jan 27, 2026
Merged

[release-1.29] Add x forwarded network header#1736
istio-testing merged 1 commit intoistio:release-1.29from
keithmattix:1-29-x-forwarded-network

Conversation

@keithmattix
Copy link
Copy Markdown
Contributor

Fixes #1735

* Initial plan

* Add x-origin-source header to inner CONNECT requests in double HBONE

Co-authored-by: keithmattix <1531662+keithmattix@users.noreply.github.com>

* Add comment explaining single HBONE codepath and tests for x-origin-source header

Co-authored-by: keithmattix <1531662+keithmattix@users.noreply.github.com>

* Rename header from x-origin-source to x-istio-origin-source

Co-authored-by: keithmattix <1531662+keithmattix@users.noreply.github.com>

* Rename header to x-istio-origin-network and refocus test on double HBONE

Co-authored-by: keithmattix <1531662+keithmattix@users.noreply.github.com>

* Add test back

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Use inbound x-istio-origin-network to know whether traffic originates from the gateway

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* fmt

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Actually check value of origin header

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Cargo fmt

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Remove incorrect TODO

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Update src/proxy.rs

Co-authored-by: Ian Rudie <ilrudie@gmail.com>

* Complete the rename

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Find/replace was too ambitious

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* Fix inverted logic

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

* fmt

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>

---------

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: keithmattix <1531662+keithmattix@users.noreply.github.com>
Co-authored-by: Ian Rudie <ilrudie@gmail.com>
@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jan 26, 2026
@istio-testing
Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@keithmattix keithmattix marked this pull request as ready for review January 26, 2026 23:44
@keithmattix keithmattix requested a review from a team as a code owner January 26, 2026 23:44
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. labels Jan 26, 2026
@keithmattix keithmattix changed the title Add x forwarded network header (#1728) [release-1.29] Add x forwarded network header Jan 26, 2026
@istio-testing istio-testing merged commit 81e1f1e into istio:release-1.29 Jan 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants