Skip to content

[release-1.29] feat: implement crl support in ztunnel (#1660)#1715

Merged
istio-testing merged 1 commit intoistio:release-1.29from
nilekhc:backport-crl-1.29
Jan 20, 2026
Merged

[release-1.29] feat: implement crl support in ztunnel (#1660)#1715
istio-testing merged 1 commit intoistio:release-1.29from
nilekhc:backport-crl-1.29

Conversation

@nilekhc
Copy link
Copy Markdown
Contributor

@nilekhc nilekhc commented Jan 12, 2026

Manual cherry-pick of #1660

  • feat: implements ca-crl support in zTunnel

Fixes #1713

@nilekhc nilekhc requested a review from a team as a code owner January 12, 2026 20:30
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 12, 2026
@Stevenjin8 Stevenjin8 changed the title feat: implement crl support in ztunnel (#1660) [release-1.29] feat: implement crl support in ztunnel (#1660) Jan 12, 2026
@keithmattix keithmattix added the do-not-merge/hold Block automatic merging of a PR. label Jan 12, 2026
@keithmattix
Copy link
Copy Markdown
Contributor

Adding a hold here since we're in the midst of branch cut and need to wait for #1712 to merge first so that the release managers are the approvers

@nilekhc
Copy link
Copy Markdown
Contributor Author

nilekhc commented Jan 12, 2026

Adding a hold here since we're in the midst of branch cut and need to wait for #1712 to merge first so that the release managers are the approvers

@keithmattix looks like #1712 is merged now.

@keithmattix
Copy link
Copy Markdown
Contributor

@nilekhc can you rebase?

* feat: implements ca-crl support in zTunnel

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: drains connection only for revoked cert

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* feat: revokes affected inbound connections only

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: refactors crl watcher

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: rejects new connections only

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: clr validation only at the HBONE layer

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: use rustls-webpki for CRL validation

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: validates CRL using webpki instead of custom implementation.

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: addresses review comments

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: implements CRL validation entirely with webpki's verify_for_usage method.

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: reverts verify_for_usage

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: removes comment

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: address review comments

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: fixes lock

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: uses Option rather than extra var

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: addresses review comments

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

* chore: fixes merge conflict

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>

---------

Signed-off-by: nilekh <1626598+nilekhc@users.noreply.github.com>
@nilekhc nilekhc requested a review from a team as a code owner January 12, 2026 22:30
@nilekhc
Copy link
Copy Markdown
Contributor Author

nilekhc commented Jan 12, 2026

@nilekhc can you rebase?

@keithmattix, done.

@keithmattix keithmattix removed the request for review from a team January 12, 2026 22:36
@keithmattix keithmattix removed the do-not-merge/hold Block automatic merging of a PR. label Jan 20, 2026
Copy link
Copy Markdown

@fjglira fjglira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing istio-testing merged commit bed5641 into istio:release-1.29 Jan 20, 2026
3 checks passed
@nilekhc nilekhc deleted the backport-crl-1.29 branch January 20, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants