Closed
Conversation
istio-testing
added
the
size/M
Stevenjin8
force-pushed
the
double-hbone/use-intended-port
branch
from
51b1d5c to
1b513f9
Compare
istio-testing
added
size/S
Stevenjin8
force-pushed
the
double-hbone/use-intended-port
branch
from
1b513f9 to
ba7a608
Compare
Contributor
|
#1565 also has this I think |
Contributor
Author
|
@ilrudie yep, just saw it after trying to merge... should update the test for it, but will put in draft for now |
istio-testing
added
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug in double hbone implementation. The authority in double hbone should have the service port (intended port), not the destination port. That is, we do not consider port mappings in the src ztunnel.