show crypto provider in ztunnel version#1545
Merged
istio-testing merged 3 commits intoistio:masterfrom May 8, 2025
Merged
Conversation
istio-testing
added
the
size/S
Stevenjin8
changed the title
ilrudie
reviewed
May 6, 2025
src/version.rs
Outdated
| pub fn new() -> Self { | ||
| #[cfg(feature = "tls-aws-lc")] | ||
| let crypto_provider = "tls-aws-lc".to_string(); | ||
| #[cfg(feature = "tls-ring")] |
Contributor
There was a problem hiding this comment.
For organization, would it make sense to have the provider be static in tls/lib.rs rather than defined here? Like TLS_VERSIONS
Line 41 in 903cf07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice if ztunnel showed the crypto provider in version.
Envoy does a similar thing, where the output looks like
or