Skip to content

[release-1.25] Better support for root certificates#1525

Closed
istio-testing wants to merge 3 commits intoistio:release-1.25from
istio-testing:cherry-pick-1510-to-release-1.25
Closed

[release-1.25] Better support for root certificates#1525
istio-testing wants to merge 3 commits intoistio:release-1.25from
istio-testing:cherry-pick-1510-to-release-1.25

Conversation

@istio-testing
Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #1510

* Split the last element of the returned response from the CA. This
  allows support for multiple roots. Note this requires a change to
Istio (which I am making) to rever the regression in 1.25.1
(istio/istio#55793).
* Split root from chain in the config_dump. Without this, it is
  impossible to know if something is a root or intermediate.
@istio-testing istio-testing requested a review from a team April 15, 2025 16:36
@istio-testing istio-testing added the release-notes-none Indicates a PR that does not require release notes. label Apr 15, 2025
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 15, 2025
@istio-testing
Copy link
Copy Markdown
Contributor Author

@istio-testing: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
test_ztunnel_release-1.25 dba9fec link true /test test
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dhawton
Copy link
Copy Markdown
Member

dhawton commented Apr 15, 2025

Looks like this and the 1.24 ones will need manual cherrypicks. Will attempt to look at tomorrow unless someone else can.

cc: @howardjohn

@Stevenjin8
Copy link
Copy Markdown
Contributor

@dhawton I can take a look at this if you haven't already. I just make PRs to release-1.24 and release-1.25?

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label May 6, 2025
@istio-testing
Copy link
Copy Markdown
Contributor Author

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dhawton dhawton closed this May 6, 2025
@dhawton
Copy link
Copy Markdown
Member

dhawton commented May 6, 2025

Handled via #1547, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR needs to be rebased before being merged release-notes-none Indicates a PR that does not require release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants