Add tooling support for rust/cargo#2184
Merged
istio-testing merged 1 commit intoistio:masterfrom Oct 20, 2022
Merged
Conversation
istio-testing
added
the
size/M
For https://github.com/istio/ztunnel. Fixes istio/ztunnel#4 This adds the rust compiler to the build tools. This brings the image from 3.5gb -> 4gb. There were some other changes to the build order of trivy to improve the image size in general. The alternative would be to make a new build-tools-rust adding this. However, since its only 500mb I didn't feel it was worthwhile; the proxy one is 8gb (and isn't even a superset) so it is a massive difference, for this case the overhead doesn't seem useful.
howardjohn
force-pushed
the
docker/rust-build-tools
branch
from
927dbfd to
516f2c7
Compare
ericvn
approved these changes
Oct 20, 2022
Contributor
ericvn
left a comment
ericvn
left a comment
There was a problem hiding this comment.
LGTM I think it's best to have a single build image for both go and rust, otherwise we will need to do some additional logic to make sure we are calling out the correct one in Makefiles, etc. Also allows one to work on both in a single make shell.
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/istio/ztunnel.
Fixes istio/ztunnel#4
This adds the rust compiler to the build tools. This brings the image from 3.5gb -> 4gb.
There were some other changes to the build order of trivy to improve the image size in general.
The alternative would be to make a new build-tools-rust adding this. However, since its only 500mb I didn't feel it was worthwhile; the proxy one is 8gb (and isn't even a superset) so it is a massive difference, for this case the overhead doesn't seem useful.