Skip to content

Add home to centos#1480

Merged
istio-testing merged 1 commit intoistio:masterfrom
brian-avery:addHomeToCentos
Apr 6, 2021
Merged

Add home to centos#1480
istio-testing merged 1 commit intoistio:masterfrom
brian-avery:addHomeToCentos

Conversation

@brian-avery
Copy link
Copy Markdown
Member

@brian-avery brian-avery commented Apr 6, 2021

This fixes the HOME directory to be consistent with the normal docker images. To test this, I've created a shell using this container, and ran make test_release_centos

@brian-avery brian-avery requested a review from a team as a code owner April 6, 2021 16:42
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 6, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 6, 2021
Copy link
Copy Markdown
Member

@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this sufficient? LGTM

@brian-avery brian-avery added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 6, 2021
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 6, 2021
@brian-avery
Copy link
Copy Markdown
Member Author

Yeah, we override the home directory in the regular docker image and not in centos. This causes it to point to two different directories depending on which image you use.

@istio-testing istio-testing merged commit 8fcd99c into istio:master Apr 6, 2021
@brian-avery brian-avery added the cherrypick/release-1.9 Set this label on a PR to auto-merge it to the release-1.9 branch label Apr 6, 2021
@istio-testing
Copy link
Copy Markdown
Contributor

In response to a cherrypick label: new pull request created: #1481

@brian-avery
Copy link
Copy Markdown
Member Author

/cherrypick release-1.9

@brian-avery
Copy link
Copy Markdown
Member Author

/cherrypick release-1.8

@istio-testing
Copy link
Copy Markdown
Contributor

@brian-avery: new pull request could not be created: failed to create pull request against istio/tools#release-1.9 from head istio-testing:cherry-pick-1480-to-release-1.9: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for istio-testing:cherry-pick-1480-to-release-1.9."}],"documentation_url":"https://docs.github.com/rest/reference/pulls#create-a-pull-request"}

Details

In response to this:

/cherrypick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing
Copy link
Copy Markdown
Contributor

@brian-avery: new pull request created: #1482

Details

In response to this:

/cherrypick release-1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brian-avery
Copy link
Copy Markdown
Member Author

/cherrypick release-1.10

@istio-testing
Copy link
Copy Markdown
Contributor

@brian-avery: new pull request created: #1483

Details

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jun 30, 2022
Shuanglu pushed a commit to Shuanglu/istio-tools that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherrypick/release-1.9 Set this label on a PR to auto-merge it to the release-1.9 branch cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants