Kafka stabiltiy test

[howardjohn]

No description provided.

[GregHanson]

@howardjohn will this test eventually change as kafka support is merged into envoy? Several PR's have started going in the past few days, such as envoyproxy/envoy#4950

[howardjohn]

@GregHanson I had no idea about that, thanks. We will need to add support to istio as well, right? Then just change port names to kafka-?

[GregHanson]

yes, eventually we will have to pull this into istio - kafka is something that comes up pretty frequently with istio in my experience. @cmluciano might be able to provide some more insight into this from an envoy perspective. As it stands now, the codec has been merged into envoy but not the filter?

[GregHanson]

but basically it sounds like envoy still has some work to do on its end, so the test as it stands now ( with basic ServiceEntry with Resolution type NONE) is definitely a good test to have for the time being

[howardjohn]

The ServiceEntry won't change when we get the envoy filter working though , it is needed because Istio won't create the entries for every instance of the headless service so they cannot talk to each other without it, unless I am doing it wrong

[sdake]

/lgtm

Great work @howardjohn! While Envoy might end up merging Kafka functionality, if it doesn't have it . today, we have a desire to dead chicken test a common set of widely used open source projects with Istio. This meets that bar IMO, and adds value to our overall testing.

If/When Envoy includes native support for handling Kafka, we can either remove this test or rework it. As things stand today, I'd like to see it merged.

I have to acknowledge I don't keep up with Envoy as I am mostly interested in the control plane, so if Envoy experts disagree on timing (as in Envoy will have this functionality in the next 3 weeks prior to 1.2 release), now is the time to say something :).

In a worse case scenario, the work would need a revert if it in some way interfered with Envoy.

[howardjohn]

@mandarjog @utka can you give owners approval

[GregHanson]

Please add a license comment to the kafka python app file. Other than that looks good. As @sdake said, it's a good base line test until more support is added in Envoy

[GregHanson]

/approve

[istio-testing]

@howardjohn: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hansel801]

Hi, have you tried Kafka with sidecar + mTLS enabled? Wondering if this works...