Skip to content

Various fixes for private cluster#4855

Merged
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:private/fixes
Jun 29, 2023
Merged

Various fixes for private cluster#4855
istio-testing merged 2 commits intoistio:masterfrom
howardjohn:private/fixes

Conversation

@howardjohn
Copy link
Copy Markdown
Member

  • Give prow deployer access to the cluster
  • Give deck access to view logs of the jobs
  • Remove ssh mount, which we no longer use
  • Cleanup presets, to avoid confusion. Effectively reverts Add some presets back #4124 which just needed a few releases to die out
  • Remove AUTH_HEADER setting, this is obsolete now - no authenitkos used

@howardjohn howardjohn requested a review from a team as a code owner June 29, 2023 14:46
@istio-policy-bot
Copy link
Copy Markdown

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 29, 2023
@istio-testing istio-testing merged commit aa24605 into istio:master Jun 29, 2023
@istio-testing
Copy link
Copy Markdown
Collaborator

@howardjohn: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key all-presets.yaml using file prow/cluster/jobs/all-presets.yaml
  • key istio-private.api.master.gen.yaml using file prow/cluster/jobs/istio-private/api/istio-private.api.master.gen.yaml
  • key istio-private.api.release-1.16.gen.yaml using file prow/cluster/jobs/istio-private/api/istio-private.api.release-1.16.gen.yaml
  • key istio-private.api.release-1.17.gen.yaml using file prow/cluster/jobs/istio-private/api/istio-private.api.release-1.17.gen.yaml
  • key istio-private.api.release-1.18.gen.yaml using file prow/cluster/jobs/istio-private/api/istio-private.api.release-1.18.gen.yaml
  • key istio-private.istio.master.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.master.gen.yaml
  • key istio-private.istio.release-1.16.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.release-1.16.gen.yaml
  • key istio-private.istio.release-1.17.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.release-1.17.gen.yaml
  • key istio-private.istio.release-1.18.gen.yaml using file prow/cluster/jobs/istio-private/istio/istio-private.istio.release-1.18.gen.yaml
  • key istio-private.proxy.master.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.master.gen.yaml
  • key istio-private.proxy.release-1.16.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.16.gen.yaml
  • key istio-private.proxy.release-1.17.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.17.gen.yaml
  • key istio-private.proxy.release-1.18.gen.yaml using file prow/cluster/jobs/istio-private/proxy/istio-private.proxy.release-1.18.gen.yaml
  • key istio-private.release-builder.master.gen.yaml using file prow/cluster/jobs/istio-private/release-builder/istio-private.release-builder.master.gen.yaml
  • key istio-private.release-builder.release-1.16.gen.yaml using file prow/cluster/jobs/istio-private/release-builder/istio-private.release-builder.release-1.16.gen.yaml
  • key istio-private.release-builder.release-1.17.gen.yaml using file prow/cluster/jobs/istio-private/release-builder/istio-private.release-builder.release-1.17.gen.yaml
  • key istio-private.release-builder.release-1.18.gen.yaml using file prow/cluster/jobs/istio-private/release-builder/istio-private.release-builder.release-1.18.gen.yaml
Details

In response to this:

  • Give prow deployer access to the cluster
  • Give deck access to view logs of the jobs
  • Remove ssh mount, which we no longer use
  • Cleanup presets, to avoid confusion. Effectively reverts Add some presets back #4124 which just needed a few releases to die out
  • Remove AUTH_HEADER setting, this is obsolete now - no authenitkos used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants