Skip to content

Fix linting issues due to upgraded shellcheck #4455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Dec 20, 2022
Merged

Fix linting issues due to upgraded shellcheck #4455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions authentikos/test/integ-simple.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ source "$ROOT/lib.sh"

timout="5m"

# shellcheck disable=SC2317
get_tokeninfo() {
local token

Expand Down
2 changes: 1 addition & 1 deletion scripts/validate_schema.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ get_opts() {
done
}

# shellcheck disable=SC2317
validate_opts() {
if [ -z "${DOCUMENT_PATH:-}" ]; then
print_error_and_exit "DOCUMENT_PATH is a required option. It must be the path to the document to validate."
Expand Down Expand Up @@ -97,7 +98,6 @@ main() {
validate_opts

validate_schema
return 1
}

main "$@"
1 change: 1 addition & 0 deletions tools/automator/automator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ROOT="$(cd -P "$(dirname -- "$0")" && pwd -P)"
# shellcheck disable=SC1090,SC1091
source "$ROOT/utils.sh"

# shellcheck disable=SC2317
cleanup() {
rm -rf "${tmp_dir:-}" "${tmp_token:-}" "${tmp_script:-}" "${tmp_git:-}"
}
Expand Down
3 changes: 2 additions & 1 deletion tools/check_release_notes.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ print_error_and_exit() {
RELEASE_NOTES_NONE_LABEL="release-notes-none"

cleanup() {
# shellcheck disable=SC2317
rm -rf "${tmp_token:-}"
}

Expand Down Expand Up @@ -96,6 +97,7 @@ get_opts() {

#This script relies on the REPO_OWNER, REPO_NAME, and PULL_NUMBER environment
#variables as defined in https://github.com/kubernetes/test-infra/blob/master/prow/jobs.md#job-environment-variables.
# shellcheck disable=SC2317
validate_opts() {
if [[ "${JOB_TYPE:-}" == "batch" ]]; then
echo "Release notes checker not applicable for batch jobs. Skipping"
Expand Down Expand Up @@ -251,7 +253,6 @@ main() {
validateNotes
checkForFiles
checkForLabel
return 1
}

main "$@"