Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions tools/prowgen/pkg/decorator/requirement.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"log"

"github.com/hashicorp/go-multierror"
"github.com/imdario/mergo"
v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/test-infra/prow/config"
Expand Down Expand Up @@ -66,13 +67,13 @@ func ApplyRequirements(job *config.JobBase, requirements, excludedRequirements [
func resolveRequirements(annotations, labels map[string]string, spec *v1.PodSpec, requirements []spec.RequirementPreset) {
if spec != nil {
for _, req := range requirements {
mergeRequirement(annotations, labels, spec.Containers, &spec.Volumes, req)
mergeRequirement(annotations, labels, spec, spec.Containers, &spec.Volumes, req)
}
}
}

// mergeRequirement will overlay the requirement on the existing job spec.
func mergeRequirement(annotations, labels map[string]string, containers []v1.Container, volumes *[]v1.Volume,
// mergeRequirement will overlay the requirement on the existing job spec. Use mergo for all keys except containers and metadata
func mergeRequirement(annotations, labels map[string]string, spec *v1.PodSpec, containers []v1.Container, volumes *[]v1.Volume,
req spec.RequirementPreset) {
for a, v := range req.Annotations {
annotations[a] = v
Expand Down Expand Up @@ -123,4 +124,10 @@ func mergeRequirement(annotations, labels map[string]string, containers []v1.Con
}
}
}

if req.PodSpec != nil {
if err := mergo.Merge(spec, req.PodSpec); err != nil {
log.Fatalf("Unable to merge PodSpec: %v", err)
}
}
}
1 change: 1 addition & 0 deletions tools/prowgen/pkg/spec/spec.go
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@ type RequirementPreset struct {
Volumes []v1.Volume `json:"volumes,omitempty"`
VolumeMounts []v1.VolumeMount `json:"volumeMounts,omitempty"`
Args []string `json:"args,omitempty"`
PodSpec *v1.PodSpec `json:"podSpec,omitempty"` // Use this field to add extra PodSpec fields except containers and metadata
}

func (r *RequirementPreset) DeepCopy() RequirementPreset {
Expand Down
2 changes: 2 additions & 0 deletions tools/prowgen/pkg/testdata/.base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ requirement_presets:
annotations:
description: "This is an annotation for a job description"
commonargs:
podSpec:
serviceAccountName: foobar
args:
- "common"
- "args"
Expand Down
2 changes: 2 additions & 0 deletions tools/prowgen/pkg/testdata/simple.gen.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.