Skip to content

Workaround prow library limitations to properly hide jobs #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 2 commits into from
Jul 14, 2021
Merged

Workaround prow library limitations to properly hide jobs #3443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab85fc
Workaround prow library limitations to properly hide jobs
howardjohn Jul 14, 2021
5f912f8
1.11
howardjohn Jul 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions prow/cluster/jobs/istio/istio/istio.istio.master.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 12 additions & 6 deletions prow/cluster/jobs/istio/istio/istio.istio.release-1.11.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 8 additions & 4 deletions prow/cluster/jobs/istio/istio/istio.istio.release-1.7.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 10 additions & 5 deletions prow/cluster/jobs/istio/istio/istio.istio.release-1.8.gen.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions prow/config/generate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,9 @@ func (cli *Client) WriteConfig(jobs config.JobConfig, fname string) {
if err := os.MkdirAll(dir, os.ModePerm); err != nil {
exit(err, "failed to create directory: "+dir)
}
// Horrible hack to workaround https://github.com/kubernetes/test-infra/issues/22888
bs = bytes.ReplaceAll(bs, []byte(` slack: {}`), []byte(` slack:
job_states_to_report: []`))
output := []byte(cli.GlobalConfig.AutogenHeader)
output = append(output, bs...)
err = ioutil.WriteFile(fname, output, 0644)
Expand Down