Skip to content

1.10 branch#3248

Closed
howardjohn wants to merge 1 commit intoistio:masterfrom
howardjohn:110-branch
Closed

1.10 branch#3248
howardjohn wants to merge 1 commit intoistio:masterfrom
howardjohn:110-branch

Conversation

@howardjohn
Copy link
Copy Markdown
Member

@howardjohn howardjohn commented Apr 6, 2021

No description provided.

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 6, 2021
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 6, 2021

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 6, 2021
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 6, 2021
ericvn
ericvn approved these changes Apr 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ericvn ericvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval since it has merge held.

@Monkeyanator Monkeyanator marked this pull request as ready for review April 6, 2021 16:27
@Monkeyanator Monkeyanator requested a review from a team as a code owner April 6, 2021 16:27
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 6, 2021
@Monkeyanator Monkeyanator added the do-not-merge/hold Block automatic merging of a PR. label Apr 6, 2021
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Apr 6, 2021

@howardjohn: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
gencheck_test-infra 3d458c1 link /test gencheck_test-infra
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Monkeyanator
Copy link
Copy Markdown
Contributor

Monkeyanator commented Apr 6, 2021

Looks like we're generating build-tools:master in a lot of places that should be build-tools:release-1.10

@ericvn
Copy link
Copy Markdown
Contributor

ericvn commented Apr 6, 2021

Found that #3215 made a change where the older master image is placed in all the jobs. As a work-around for now, the 5 lines or so were commented out for the run, so only the overall image is updated. Will close this PR and merge changes in another.

@ericvn ericvn closed this Apr 6, 2021
@Monkeyanator
Copy link
Copy Markdown
Contributor

Monkeyanator commented Apr 6, 2021

Closing in favor of #3249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericvn ericvn ericvn approved these changes

Assignees

No one assigned

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. do-not-merge/hold Block automatic merging of a PR. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@howardjohn @istio-testing @Monkeyanator @ericvn