Skip to content

update istio/proxy to use prowbazel 0.5.2 with gcc-7/g++-7#1221

Merged
istio-testing merged 1 commit intoistio:masterfrom
yangminzhu:yaml
Apr 19, 2019
Merged

update istio/proxy to use prowbazel 0.5.2 with gcc-7/g++-7#1221
istio-testing merged 1 commit intoistio:masterfrom
yangminzhu:yaml

Conversation

@yangminzhu
Copy link
Contributor

For istio/proxy#2179

/assign @icygalz
I only updated the prowbazel for istio/proxy in master and wasm branch, not including 1.1 and other periodic jobs. I assume only the istio/proxy in master and wasm branch will need to compile with the latest istio/proxy code, right?

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 18, 2019
@istio-testing istio-testing requested review from icygalz and utka April 18, 2019 23:48
@icygalz
Copy link
Contributor

icygalz commented Apr 19, 2019

/lgtm
/approve

thank you again for splitting your PR.

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: icygalz, yangminzhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit c3b1c2d into istio:master Apr 19, 2019
@istio-testing
Copy link
Collaborator

@yangminzhu: Updated the job-config configmap using the following files:

  • key istio.proxy.master.yaml using file prow/cluster/jobs/istio/proxy/istio.proxy.master.yaml
  • key istio.proxy.wasm.yaml using file prow/cluster/jobs/istio/proxy/istio.proxy.wasm.yaml
Details

In response to this:

For istio/proxy#2179

/assign @icygalz
I only updated the prowbazel for istio/proxy in master and wasm branch, not including 1.1 and other periodic jobs. I assume only the istio/proxy in master and wasm branch will need to compile with the latest istio/proxy code, right?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yangminzhu yangminzhu deleted the yaml branch April 19, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants