Merged
Conversation
kyessenov
reviewed
Dec 6, 2016
| @@ -0,0 +1,77 @@ | |||
| // Copyright (C) Extensible Service Proxy Authors | |||
| # | ||
| ################################################################################ | ||
| # | ||
| package(default_visibility = ["//visibility:private"]) |
Contributor
There was a problem hiding this comment.
Make it public or same as api_manager?
Contributor
|
You should keep BULD file, and change |
Contributor
Author
|
Not easy to make it bazel buildable. Need to change many includes too. We can do that later. For now, not to add BUILD as not to break build for other codes. |
lizan
approved these changes
Dec 6, 2016
Contributor
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
Please open an issue for making this buildable.
kyessenov
approved these changes
Dec 6, 2016
duderino
pushed a commit
that referenced
this pull request
Aug 13, 2019
kyessenov
pushed a commit
to kyessenov/proxy
that referenced
this pull request
Jul 12, 2022
add baggage to dynamic metadata
YaoZengzeng
pushed a commit
to YaoZengzeng/proxy
that referenced
this pull request
Jun 28, 2024
sync with the master of istio proxy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.