Skip to content

update extensions doc#4248

Merged
istio-testing merged 5 commits intoistio:masterfrom
zirain:buf-gen-docs
Nov 28, 2022
Merged

update extensions doc#4248
istio-testing merged 5 commits intoistio:masterfrom
zirain:buf-gen-docs

Conversation

@zirain
Copy link
Member

@zirain zirain commented Nov 28, 2022

@zirain zirain requested a review from a team November 28, 2022 03:43
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 28, 2022
@zirain
Copy link
Member Author

zirain commented Nov 28, 2022

/test test

@istio-testing istio-testing merged commit fbcf19c into istio:master Nov 28, 2022
@zirain zirain deleted the buf-gen-docs branch November 29, 2022 00:36
@zirain
Copy link
Member Author

zirain commented Nov 29, 2022

@istio-testing
Copy link
Collaborator

@zirain: new pull request created: #4251

Details

In response to this:

https://deploy-preview-12312--preliminary-istio.netlify.app/latest/docs/reference/config/proxy_extensions/stats/

cherry-pick to v1.16

/cherrypick release-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link

ericvn commented Dec 9, 2022

Question is if we updated the format of items from snake_case to CamelCase such as:

- <td><code>log_window_duration</code></td>
+ <td><code>logWindowDuration</code></td>

Which I am noting in the new update reference docs: istio/istio.io#12348

@ericvn
Copy link

ericvn commented Dec 10, 2022

@kyessenov Noted in Slack that this change was a mistake: Wasm extensions like MX parse as JSON and can't handle camelCase.

There needs to be another update to fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants