Skip to content

stats: support block_all and allow_any routes #4211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
istio-testing merged 1 commit into from
Nov 16, 2022
Merged

stats: support block_all and allow_any routes #4211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 30 additions & 23 deletions source/extensions/filters/http/istio_stats/istio_stats.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,29 +821,36 @@ class IstioStatsFilter : public Http::PassThroughFilter,
service_host_name = service_host;
}
}
const auto cluster_info = info.upstreamClusterInfo();
if (cluster_info && cluster_info.value()) {
const auto& cluster_name = cluster_info.value()->name();
if (cluster_name == "BlackHoleCluster" ||
cluster_name == "PassthroughCluster" ||
cluster_name == "InboundPassthroughClusterIpv4" ||
cluster_name == "InboundPassthroughClusterIpv6") {
service_host_name = cluster_name;
} else {
const auto& filter_metadata =
cluster_info.value()->metadata().filter_metadata();
const auto& it = filter_metadata.find("istio");
if (it != filter_metadata.end()) {
const auto& services_it = it->second.fields().find("services");
if (services_it != it->second.fields().end()) {
const auto& services = services_it->second.list_value();
if (services.values_size() > 0) {
const auto& service = services.values(0).struct_value().fields();
const auto& host_it = service.find("host");
if (host_it != service.end()) {
service_host = host_it->second.string_value();
service_host_name =
service_host.substr(0, service_host.find_first_of('.'));
if (info.getRouteName() == "block_all") {
service_host_name = "BlackHoleCluster";
} else if (info.getRouteName() == "allow_any") {
service_host_name = "PassthroughCluster";
} else {
const auto cluster_info = info.upstreamClusterInfo();
if (cluster_info && cluster_info.value()) {
const auto& cluster_name = cluster_info.value()->name();
if (cluster_name == "BlackHoleCluster" ||
cluster_name == "PassthroughCluster" ||
cluster_name == "InboundPassthroughClusterIpv4" ||
cluster_name == "InboundPassthroughClusterIpv6") {
service_host_name = cluster_name;
} else {
const auto& filter_metadata =
cluster_info.value()->metadata().filter_metadata();
const auto& it = filter_metadata.find("istio");
if (it != filter_metadata.end()) {
const auto& services_it = it->second.fields().find("services");
if (services_it != it->second.fields().end()) {
const auto& services = services_it->second.list_value();
if (services.values_size() > 0) {
const auto& service =
services.values(0).struct_value().fields();
const auto& host_it = service.find("host");
if (host_it != service.end()) {
service_host = host_it->second.string_value();
service_host_name =
service_host.substr(0, service_host.find_first_of('.'));
}
}
}
}
Expand Down