stats(native): fixes to align with wasm stats#4125
Merged
istio-testing merged 2 commits intoistio:masterfrom Oct 19, 2022
Merged
stats(native): fixes to align with wasm stats#4125istio-testing merged 2 commits intoistio:masterfrom
istio-testing merged 2 commits intoistio:masterfrom
Conversation
istio-testing
added
the
size/L
lei-tang
reviewed
Oct 19, 2022
| @@ -1,8 +1,5 @@ | |||
| field_separator: ";.;" | |||
| definitions: | |||
| - name: requests_total | |||
Contributor
There was a problem hiding this comment.
Why is requests_total deleted?
Contributor
Author
There was a problem hiding this comment.
This test case was changing the value for a standard metric. I don't think we want to support this feature.
Signed-off-by: Kuat Yessenov <kuat@google.com>
Contributor
Author
|
/retest |
lei-tang
approved these changes
Oct 19, 2022
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/cherrypick release-1.16 |
kyessenov
added
the
cherrypick/release-1.16
Collaborator
|
@kyessenov: #4125 failed to apply on top of branch "release-1.16": DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
@kyessenov: new issue could not be created for failed cherrypick: status code 410 not one of [201], body: {"message":"Issues are disabled for this repo","documentation_url":"https://docs.github.com/v3/issues/"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Collaborator
|
In response to a cherrypick label: #4125 failed to apply on top of branch "release-1.16": |
Collaborator
|
In response to a cherrypick label: new issue could not be created for failed cherrypick: status code 410 not one of [201], body: {"message":"Issues are disabled for this repo","documentation_url":"https://docs.github.com/v3/issues/"} |
kyessenov
added a commit
to kyessenov/proxy
that referenced
this pull request
Oct 20, 2022
* fixes Signed-off-by: Kuat Yessenov <kuat@google.com> * handle all wasm properties Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com>
istio-testing
pushed a commit
that referenced
this pull request
Oct 21, 2022
* stats(native): use SAN namespace by default (#4117) * stats(native): use SAN namespace by default Signed-off-by: Kuat Yessenov <kuat@google.com> * format Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com> * workload metadata: harden parsing (#4120) * workload metadata: harden parsing Signed-off-by: Kuat Yessenov <kuat@google.com> * fix test Signed-off-by: Kuat Yessenov <kuat@google.com> * fix test Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com> * stats(native): fixes to align with wasm stats (#4125) * fixes Signed-off-by: Kuat Yessenov <kuat@google.com> * handle all wasm properties Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat Yessenov <kuat@google.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kuat Yessenov kuat@google.com
Fix an error in parsing in Wasm stats for endpoint encoding (parts == 4 leads to crash).
Adds fallbacks to native stats for endpoint encoding, blackhole/passthrough.
Handle empty values properly (should be unknown).
Finish CEL expression support.