Disable cloud trace for envoy prototype.#39
Conversation
kyessenov
left a comment
There was a problem hiding this comment.
You can drop api_manager from envoy.conf now.
|
I remember Lizan wanted to retain api_manager in envoy-esp.conf. Do we still need it @lizan? |
|
I'd prefer keeping it but either is fine since the file is for local testing only. |
|
Okay, will keep it for now, we can remove it later if needed. |
|
Let us remove "api_manager". If auth is added, we can add it back as "auth_pkey_server", same for meta data server |
|
Remove once |
|
You are right. It is still hardcoded in RunHTTPRequest. We can use a separate PR to change RunHTTPRequest to get host name out of URL, make it as cluster name. and remove "ap_manager" or change it to whatever it is needed. |
|
I'd prefer if we did not need api_manager for the mixer client build of ESP. |
Fixes MAISTRA-1478: latest updates from upstream
…hanges update Envoy to bfe0463d + update from istio/proxy to 1.26.3
To prevent envoy crush if removing api_manager cluster from envoy-esp.conf.