Skip to content

Disable cloud trace for envoy prototype.#39

Merged
chowchow316 merged 2 commits intoistio:masterfrom
chowchow316:disable-cloud-trace
Jan 9, 2017
Merged

Disable cloud trace for envoy prototype.#39
chowchow316 merged 2 commits intoistio:masterfrom
chowchow316:disable-cloud-trace

Conversation

@chowchow316
Copy link
Contributor

To prevent envoy crush if removing api_manager cluster from envoy-esp.conf.

@chowchow316 chowchow316 requested a review from kyessenov January 7, 2017 00:43
@chowchow316 chowchow316 self-assigned this Jan 7, 2017
Copy link
Contributor

@kyessenov kyessenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop api_manager from envoy.conf now.

@chowchow316
Copy link
Contributor Author

I remember Lizan wanted to retain api_manager in envoy-esp.conf. Do we still need it @lizan?

@lizan
Copy link
Contributor

lizan commented Jan 9, 2017

I'd prefer keeping it but either is fine since the file is for local testing only. api_manager is still needed if you enable auth and/or metadata.

@chowchow316
Copy link
Contributor Author

Okay, will keep it for now, we can remove it later if needed.

@chowchow316 chowchow316 merged commit 8f944e6 into istio:master Jan 9, 2017
@chowchow316 chowchow316 deleted the disable-cloud-trace branch January 9, 2017 18:31
@qiwzhang
Copy link
Contributor

qiwzhang commented Jan 9, 2017

Let us remove "api_manager". If auth is added, we can add it back as "auth_pkey_server", same for meta data server

@lizan
Copy link
Contributor

lizan commented Jan 9, 2017

Remove once RunHTTPRequest is no longer hardcoded with "api_manager"?

@qiwzhang
Copy link
Contributor

qiwzhang commented Jan 9, 2017

You are right. It is still hardcoded in RunHTTPRequest. We can use a separate PR to change RunHTTPRequest to get host name out of URL, make it as cluster name. and remove "ap_manager" or change it to whatever it is needed.

@kyessenov
Copy link
Contributor

I'd prefer if we did not need api_manager for the mixer client build of ESP.
That means removing the api_manager cluster definition (presently, removing it may cause a segfault depending on the api_manager features.)
We can have another build that has api_manager.

brian-avery pushed a commit to brian-avery/proxy-istio that referenced this pull request Sep 11, 2020
Fixes MAISTRA-1478: latest updates from upstream
howardjohn pushed a commit that referenced this pull request Apr 15, 2021
jwendell pushed a commit to jwendell/proxy that referenced this pull request Sep 5, 2025
…hanges

update Envoy to bfe0463d + update from istio/proxy to 1.26.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants