Automator: update envoy@ in istio/proxy@master

[istio-testing]

Generated by Automator - 2022-04-11T01:26:58+00:00

[ericvn]

Related to envoyproxy/envoy@6d7f5ab? @istio/wg-networking-maintainers-data-plane

[PiotrSikora]

Related to envoyproxy/envoy@6d7f5ab? @istio/wg-networking-maintainers-data-plane

The failure building .wasm modules is definitely because of that change, but the fix is easy (@com_google_absl update), and I warned about this ahead of time: proxy-wasm/proxy-wasm-cpp-sdk#132 (comment).

I'm a bit confused about the visibility failures, since @envoy//source/extensions/common/wasm:wasm_lib is marked as public, but I didn't dig futher into it.

Anyway, someone should fix the build, since the next Envoy release is around the corner.

[kyessenov]

/assign @kyessenov

[kyessenov]

I tried a fresh build. After 4h build on 48 core machine (!!!) linkage failed:

wasm-ld: error: --shared-memory is disallowed by config.pb.o because it was not compiled with 'atomics' or 'bulk-memory' features.
emcc: error: '/home/kuat/.cache/bazel/_bazel_kuat/c9ce937492879f803e7d5d4bb6e36e5c/sandbox/linux-sandbox/3774/execroot/io_istio_proxy/external/emscripten_bin_linux/bin/wasm-ld -o bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/proxy_wasm_attributegen.wasm bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/_objs/proxy_wasm_attributegen/plugin.o bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/_objs/proxy_wasm_attributegen/context.o bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/_objs/proxy_wasm_attributegen/util.o bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/attributegen/libconfig_proto.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/extensions/common/wasm/libjson_util.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/types/libbad_optional_access.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/time/libtime.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/strings/libstrings.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/strings/libinternal.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/base/libbase.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/base/libspinlock_wait.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/base/libthrow_delegate.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/base/libraw_logging_internal.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/base/liblog_severity.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/numeric/libint128.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/time/internal/cctz/libtime_zone.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_absl/absl/time/internal/cctz/libcivil_time.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/proxy_wasm_cpp_sdk/libproxy_wasm_intrinsics_proto.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_protobuf/libprotobuf.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/com_google_protobuf/libprotobuf_lite.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/envoy/bazel/foreign_cc/zlib/lib/libz.a bazel-out/wasm-fastbuild-ST-2f6523f8f030/bin/external/proxy_wasm_cpp_sdk/libproxy_wasm_intrinsics.a -L/home/kuat/.cache/bazel/_bazel_kuat/c9ce937492879f803e7d5d4bb6e36e5c/external/emscripten_bin_linux/emscripten/cache/sysroot/lib/wasm32-emscripten /home/kuat/.cache/bazel/_bazel_kuat/c9ce937492879f803e7d5d4bb6e36e5c/external/emscripten_bin_linux/emscripten/cache/sysroot/lib/wasm32-emscripten/crtbegin.o /home/kuat/.cache/bazel/_bazel_kuat/c9ce937492879f803e7d5d4bb6e36e5c/external/emscripten_bin_linux/emscripten/cache/sysroot/lib/wasm32-emscripten/crt1_reactor.o -lGL-mt -lal -lhtml5 -lprintf_long_double-mt-debug -lstandalonewasm -lstubs-debug -lnoexit -lc-mt-debug -ldlmalloc-mt -lcompiler_rt-mt -lc++-mt-noexcept -lc++abi-mt-noexcept -lsockets-mt -mllvm -combiner-global-alias-analysis=false -mllvm -enable-emscripten-sjlj -mllvm -disable-lsr --import-undefined --import-memory --shared-memory --strip-debug --export-if-defined=malloc --export-if-defined=_emscripten_thread_init --export-if-defined=_emscripten_thread_exit --export-if-defined=_emscripten_thread_crashed --export-if-defined=emscripten_tls_init --export-if-defined=emscripten_current_thread_process_queued_calls --export-if-defined=pthread_self --export-if-defined=__start_em_asm --export-if-defined=__stop_em_asm --export=emscripten_stack_get_end --export=emscripten_stack_get_free --export=emscripten_stack_get_base --export=emscripten_stack_init --export=stackSave --export=stackRestore --export=stackAlloc --export=__errno_location --export=emscripten_dispatch_to_thread_ --export=_emscripten_thread_free_data --export=_emscripten_allow_main_runtime_queued_calls --export=emscripten_main_browser_thread_id --export=emscripten_main_thread_process_queued_calls --export=emscripten_run_in_main_runtime_thread_js --export=emscripten_stack_set_limits --export=emscripten_sync_run_in_main_thread_2 --export=emscripten_sync_run_in_main_thread_4 --export=emscripten_builtin_memalign --export=malloc --export=free --export-table -z stack-size=5242880 --initial-memory=8388608 --entry=_initialize --max-memory=8388608 --global-base=1024' failed (returned 1)

[PiotrSikora]

wasm-ld: error: --shared-memory is disallowed by config.pb.o because it was not compiled with 'atomics' or 'bulk-memory' features.

This suggests that it was compiled with -pthread. Did you update abseil to include abseil/abseil-cpp@eb3db08?

[kyessenov]

@PiotrSikora I don't see any abseil override here. Isn't it just imported from envoy?

[PiotrSikora]

@Kaut it is, which is why you need to add the override. Alternatively, we could update it in Envoy (which is probably safer long-term), but it's not strictly needed there, as Envoy doesn't have any Wasm plugins that use abseil.

[kyessenov]

Ok, will try.

[ericvn]

#3801 is the PR where work is being done to fix the build problems. Once that merges, the next automated merge in this PR should hopefully pass the tests.

[zirain]

/retest-required

[zirain]

/test test_proxy