add bazel build args into test framework and do not fail silently#3025
Closed
bianpengyuan wants to merge 2 commits intoistio:release-1.7from
Closed
add bazel build args into test framework and do not fail silently#3025bianpengyuan wants to merge 2 commits intoistio:release-1.7from
bianpengyuan wants to merge 2 commits intoistio:release-1.7from
Conversation
istio-testing
added
the
do-not-merge/work-in-progress
googlebot
added
the
cla: yes
Collaborator
|
Skipping CI for Draft Pull Request. |
istio-testing
added
the
size/M
Contributor
Author
|
/test all |
Contributor
Author
|
/test all |
istio-testing
removed
the
do-not-merge/work-in-progress
|
This will be fixed by: #3029 (included this patch as a result). Think we can close this, can you confirm @bianpengyuan ? |
Contributor
Author
|
Ah yes, nvm. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: