[release-1.7] extension config server#2960
[release-1.7] extension config server#2960kyessenov wants to merge 14 commits intoistio:release-1.7from
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
istio-testing
added
the
size/XL
googlebot
added
the
cla: yes
Signed-off-by: Kuat Yessenov <kuat@google.com>
jwendell
changed the title
|
@kyessenov @mandarjog @douglas-reid is this PR ready? Could you append a GitHub issue? |
|
This is a draft. I'm using it to test against 1.7 proxy since it diverged from upstream envoy. |
Signed-off-by: Kuat Yessenov <kuat@google.com>
Signed-off-by: Kuat Yessenov <kuat@google.com>
JimmyCYJ
left a comment
JimmyCYJ
left a comment
There was a problem hiding this comment.
Didn't know that this PR is not ready. Will review again.
|
@kyessenov So, is this intended to be in 1.7.0? We have a code freeze tomorrow. |
|
This PR doesn't affect the release 1.7 binary in any way. I'm mostly interested in testing 1.7 proxy, so you don't have to merge this. If it doesn't, I'll just move it to master. |
|
Awesome, thanks for the info. |
| params.Vars["ServerMetadata"] = params.LoadTestData("testdata/server_node_metadata.json.tmpl") | ||
| params.Vars["ServerHTTPFilters"] = params.LoadTestData("testdata/filters/stackdriver_inbound.yaml.tmpl") | ||
| params.Vars["ClientHTTPFilters"] = params.LoadTestData("testdata/filters/stackdriver_outbound.yaml.tmpl") | ||
| params.Vars["ServerHTTPFilters"] = params.LoadTestData("testdata/filters/mx_inbound.yaml.tmpl") + "\n" + |
There was a problem hiding this comment.
Params setup seems repetitive, consider factoring it out.
| ) | ||
|
|
||
| // Convert to an envoy config. | ||
| // It so happens that 1.7 and 1.8 match in terms protobuf bytes, but not JSON. |
There was a problem hiding this comment.
Which part is different? The additional StringValue wrapping?
There was a problem hiding this comment.
vm_config got renamed to inline_vm_config.
| log.Fatal(err) | ||
| } | ||
| server = extensionserver.New(context.Background()) | ||
| discoveryservice.RegisterAggregatedDiscoveryServiceServer(grpcServer, server) |
There was a problem hiding this comment.
Is ADS being used anywhere?
I only see ECDS in the example above with otherwise static config.
There was a problem hiding this comment.
not here, but it could be used. envoy doesn't support multiple ADS streams though.
|
Moving to master. |
6 participants
This implements an xDS server to serve extension configs (Wasm primarily).
There is no UI so open to suggestions how to make it usable :)
The idea is to deploy this in the cluster as a federated control plane server, and point to it via EnvoyFilters.
/cc @mandarjog
/cc @douglas-reid