Skip to content

t-test prototype#28

Closed
lizan wants to merge 2 commits intoistio:masterfrom
lizan:t_test
Closed

t-test prototype#28
lizan wants to merge 2 commits intoistio:masterfrom
lizan:t_test

Conversation

@lizan
Copy link
Contributor

@lizan lizan commented Jan 4, 2017

Passes with #27

@lizan lizan self-assigned this Jan 4, 2017
@lizan lizan requested a review from qiwzhang January 4, 2017 18:39
@qiwzhang
Copy link
Contributor

qiwzhang commented Jan 4, 2017

Could you describe how it is done? I saw the binary is using envoy-esp, but Nginx is loaded, and every where name is using Nginx. and nginx config is used inside t test. If Nginx is used, but we don't have ESP module code for Nginx here

@lizan
Copy link
Contributor Author

lizan commented Jan 4, 2017

I tried to make the t-test can share most part with our nginx test as well, so I didn't delete the nginx specific part from check.t.

Instead of $t->run, it use $t->run_daemon to start an envoy-esp, config file generated in ApiManager.pm.

In BUILD file nginx actually pointed to envoy-esp.

@kyessenov
Copy link
Contributor

This is confusing. Can you replace all "nginx" occurrences with envoy?
What's the migration plan for the t-test code? Are we moving it to this repo?

@lizan
Copy link
Contributor Author

lizan commented Jan 4, 2017

@kyessenov This is just a prototype to review.
I will update with correct words (probably "proxy" instead of envoy or nginx).

Let's discuss migration plan later.

@qiwzhang
Copy link
Contributor

qiwzhang commented Jan 4, 2017

I see. This is good, a big step in the right direction. A couple suggestions

  1. for easy code review, could you use a separate PR to just copy the existing codes. Then this PR just show the diff?
  2. may be we can create an abstract layer to handle Nginx/Envoy stuff, such as config and running.

such as:

$t = proxy_test;
$t->set_config(
"listen_port": xxx
"service_config_file": xxx
)
$t->run()

Ideally, at bazel proxy.bzl level, we have flag to switch proxy for Nginx or Envoy.

@mandarjog
Copy link
Contributor

Are t tests still the preferred framework?
I thought we were moving to a go based testing fw. @lizan ?

@lizan lizan closed this Jan 27, 2017
qiwzhang added a commit that referenced this pull request Feb 16, 2018
* Update to latest mixer api.

* Supports string_map type.

* Add Duration type.

* Change duration signature

* Use std::chrono:nanoseconds for duration.
fpesce pushed a commit that referenced this pull request Jun 30, 2020
* Update SHA for 1.5

* remove blank lines

* Change project

* Add support for project to workspace
howardjohn pushed a commit that referenced this pull request Sep 7, 2022
revert internal transport hack
dcillera pushed a commit to dcillera/proxy-1 that referenced this pull request Jul 2, 2025
Signed-off-by: Zuzana Miklankova <zmiklank@redhat.com>
jwendell pushed a commit to jwendell/proxy that referenced this pull request Sep 5, 2025
This reverts commit 70f0716.

Reson for the revert is, that we already have golang 1.24 rpms available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants