Skip to content

wasm: remove free symbol export #2789

Merged
istio-testing merged 1 commit intoistio:masterfrom
Shikugawa:fix-symbol
Mar 30, 2020
Merged

wasm: remove free symbol export #2789
istio-testing merged 1 commit intoistio:masterfrom
Shikugawa:fix-symbol

Conversation

@Shikugawa
Copy link
Copy Markdown
Member

@Shikugawa Shikugawa commented Mar 28, 2020

What this PR does / why we need it:
export _free is required any more with this fix envoyproxy/envoy-wasm#404, No?

@Shikugawa Shikugawa requested a review from a team March 28, 2020 12:56
@istio-policy-bot
Copy link
Copy Markdown

😊 Welcome @Shikugawa! This is either your first contribution to the Istio proxy repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 28, 2020
@istio-testing
Copy link
Copy Markdown
Collaborator

Hi @Shikugawa. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 28, 2020
@mandarjog
Copy link
Copy Markdown
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 28, 2020
@istio-testing istio-testing merged commit d0f2621 into istio:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants